Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-13 Thread Tariq Toukan
On 2/12/2019 8:20 PM, Ilias Apalodimas wrote: > Hi Alexander, > > On Tue, Feb 12, 2019 at 10:13:30AM -0800, Alexander Duyck wrote: >> On Tue, Feb 12, 2019 at 7:16 AM Eric Dumazet wrote: >>> >>> >>> >>> On 02/12/2019 04:39 AM, Tariq Toukan wrote: On 2/11/2019 7:14 PM, Eric Dumazet

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-13 Thread Tariq Toukan
On 2/12/2019 8:13 PM, Alexander Duyck wrote: > On Tue, Feb 12, 2019 at 7:16 AM Eric Dumazet wrote: >> >> >> >> On 02/12/2019 04:39 AM, Tariq Toukan wrote: >>> >>> >>> On 2/11/2019 7:14 PM, Eric Dumazet wrote: On 02/11/2019 12:53 AM, Tariq Toukan wrote: > > Hi, > >

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-12 Thread Ilias Apalodimas
Hi Alexander, On Tue, Feb 12, 2019 at 10:13:30AM -0800, Alexander Duyck wrote: > On Tue, Feb 12, 2019 at 7:16 AM Eric Dumazet wrote: > > > > > > > > On 02/12/2019 04:39 AM, Tariq Toukan wrote: > > > > > > > > > On 2/11/2019 7:14 PM, Eric Dumazet wrote: > > >> > > >> > > >> On 02/11/2019 12:53 AM

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-12 Thread Alexander Duyck
On Tue, Feb 12, 2019 at 7:16 AM Eric Dumazet wrote: > > > > On 02/12/2019 04:39 AM, Tariq Toukan wrote: > > > > > > On 2/11/2019 7:14 PM, Eric Dumazet wrote: > >> > >> > >> On 02/11/2019 12:53 AM, Tariq Toukan wrote: > >>> > >> > >>> Hi, > >>> > >>> It's great to use the struct page to store its d

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-12 Thread Eric Dumazet
On 02/12/2019 04:39 AM, Tariq Toukan wrote: > > > On 2/11/2019 7:14 PM, Eric Dumazet wrote: >> >> >> On 02/11/2019 12:53 AM, Tariq Toukan wrote: >>> >> >>> Hi, >>> >>> It's great to use the struct page to store its dma mapping, but I am >>> worried about extensibility. >>> page_pool is evolvin

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-12 Thread Tariq Toukan
On 2/12/2019 3:49 PM, Jesper Dangaard Brouer wrote: > On Tue, 12 Feb 2019 12:39:59 + > Tariq Toukan wrote: > >> On 2/11/2019 7:14 PM, Eric Dumazet wrote: >>> >>> On 02/11/2019 12:53 AM, Tariq Toukan wrote: >>> Hi, It's great to use the struct page to store its dma

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-12 Thread Jesper Dangaard Brouer
On Tue, 12 Feb 2019 12:39:59 + Tariq Toukan wrote: > On 2/11/2019 7:14 PM, Eric Dumazet wrote: > > > > On 02/11/2019 12:53 AM, Tariq Toukan wrote: > >> > > > >> Hi, > >> > >> It's great to use the struct page to store its dma mapping, but I am > >> worried about extensibility. > >> pa

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-12 Thread Tariq Toukan
On 2/11/2019 7:14 PM, Eric Dumazet wrote: > > > On 02/11/2019 12:53 AM, Tariq Toukan wrote: >> > >> Hi, >> >> It's great to use the struct page to store its dma mapping, but I am >> worried about extensibility. >> page_pool is evolving, and it would need several more per-page fields. >> One of

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-11 Thread Eric Dumazet
On 02/11/2019 12:53 AM, Tariq Toukan wrote: > > Hi, > > It's great to use the struct page to store its dma mapping, but I am > worried about extensibility. > page_pool is evolving, and it would need several more per-page fields. > One of them would be pageref_bias, a planned optimization to

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-11 Thread Tariq Toukan
On 2/11/2019 2:12 PM, Matthew Wilcox wrote: > On Mon, Feb 11, 2019 at 08:53:19AM +, Tariq Toukan wrote: >> It's great to use the struct page to store its dma mapping, but I am >> worried about extensibility. >> page_pool is evolving, and it would need several more per-page fields. >> One of t

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-11 Thread Matthew Wilcox
On Mon, Feb 11, 2019 at 08:53:19AM +, Tariq Toukan wrote: > It's great to use the struct page to store its dma mapping, but I am > worried about extensibility. > page_pool is evolving, and it would need several more per-page fields. > One of them would be pageref_bias, a planned optimization

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-11 Thread Tariq Toukan
On 2/7/2019 11:42 PM, Ilias Apalodimas wrote: > Hi Matthew, > > On Thu, Feb 07, 2019 at 01:34:00PM -0800, Matthew Wilcox wrote: >> On Thu, Feb 07, 2019 at 01:25:19PM -0800, David Miller wrote: >>> From: Ilias Apalodimas >>> Date: Thu, 7 Feb 2019 17:20:34 +0200 >>> Well updating struct page

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-07 Thread Ilias Apalodimas
Hi Matthew, On Thu, Feb 07, 2019 at 01:34:00PM -0800, Matthew Wilcox wrote: > On Thu, Feb 07, 2019 at 01:25:19PM -0800, David Miller wrote: > > From: Ilias Apalodimas > > Date: Thu, 7 Feb 2019 17:20:34 +0200 > > > > > Well updating struct page is the final goal, hence the comment. I am > > > mo

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-07 Thread Ilias Apalodimas
Hi David, On Thu, Feb 07, 2019 at 01:25I:19PM -0800, David Miller wrote: > From: Ilias Apalodimas > Date: Thu, 7 Feb 2019 17:20:34 +0200 > > > Well updating struct page is the final goal, hence the comment. I am mostly > > looking for opinions here since we are trying to store dma addresses whic

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-07 Thread Matthew Wilcox
On Thu, Feb 07, 2019 at 01:25:19PM -0800, David Miller wrote: > From: Ilias Apalodimas > Date: Thu, 7 Feb 2019 17:20:34 +0200 > > > Well updating struct page is the final goal, hence the comment. I am mostly > > looking for opinions here since we are trying to store dma addresses which > > are >

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-07 Thread David Miller
From: Ilias Apalodimas Date: Thu, 7 Feb 2019 17:20:34 +0200 > Well updating struct page is the final goal, hence the comment. I am mostly > looking for opinions here since we are trying to store dma addresses which are > irrelevant to pages. Having dma_addr_t definitions in mm-related headers is

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-07 Thread Ilias Apalodimas
Hi Matthew, On Thu, Feb 07, 2019 at 07:07:45AM -0800, Matthew Wilcox wrote: > On Thu, Feb 07, 2019 at 04:36:36PM +0200, Ilias Apalodimas wrote: > > +/* Until we can update struct-page, have a shadow struct-page, that > > + * include our use-case > > + * Used to store retrieve dma addresses from ne

Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t

2019-02-07 Thread Matthew Wilcox
On Thu, Feb 07, 2019 at 04:36:36PM +0200, Ilias Apalodimas wrote: > +/* Until we can update struct-page, have a shadow struct-page, that > + * include our use-case > + * Used to store retrieve dma addresses from network drivers. > + * Never access this directly, use helper functions provided > + *