Re: [Patch nf-next] nf_conntrack: fix error path in nf_conntrack_pernet_init()

On Wed, Jan 23, 2019 at 12:58:57PM -0800, Cong Wang wrote: > When nf_ct_netns_get() fails, it should clean up itself, > its caller doesn't need to call nf_conntrack_fini_net(). > > nf_conntrack_init_net() is called after registering sysctl > and proc, so its cleanup function should be called befor

Re: [Patch nf-next] nf_conntrack: fix error path in nf_conntrack_pernet_init()

Cong Wang wrote: > When nf_ct_netns_get() fails, it should clean up itself, > its caller doesn't need to call nf_conntrack_fini_net(). Thanks a lot for fixing this!

[Patch nf-next] nf_conntrack: fix error path in nf_conntrack_pernet_init()

When nf_ct_netns_get() fails, it should clean up itself, its caller doesn't need to call nf_conntrack_fini_net(). nf_conntrack_init_net() is called after registering sysctl and proc, so its cleanup function should be called before unregistering sysctl and proc. Fixes: ba3fbe663635 ("netfilter: nf