Re: [Patch net v2] xfrm: clean up xfrm protocol checks

2019-03-27 Thread Steffen Klassert
On Mon, Mar 25, 2019 at 06:42:58PM +0800, Herbert Xu wrote: > On Fri, Mar 22, 2019 at 04:26:19PM -0700, Cong Wang wrote: > > In commit 6a53b7593233 ("xfrm: check id proto in validate_tmpl()") > > I introduced a check for xfrm protocol, but according to Herbert > > IPSEC_PROTO_ANY should only be use

Re: [Patch net v2] xfrm: clean up xfrm protocol checks

2019-03-25 Thread Herbert Xu
On Fri, Mar 22, 2019 at 04:26:19PM -0700, Cong Wang wrote: > In commit 6a53b7593233 ("xfrm: check id proto in validate_tmpl()") > I introduced a check for xfrm protocol, but according to Herbert > IPSEC_PROTO_ANY should only be used as a wildcard for lookup, so > it should be removed from validate_

[Patch net v2] xfrm: clean up xfrm protocol checks

2019-03-22 Thread Cong Wang
In commit 6a53b7593233 ("xfrm: check id proto in validate_tmpl()") I introduced a check for xfrm protocol, but according to Herbert IPSEC_PROTO_ANY should only be used as a wildcard for lookup, so it should be removed from validate_tmpl(). And, IPSEC_PROTO_ANY is expected to only match 3 IPSec-spe