Re: [Patch net 5/5] net_sched: convert tcf_exts from list to flex_array

2016-08-09 Thread Cong Wang
On Tue, Aug 9, 2016 at 1:03 AM, Amir Vadai wrote: > >> -#define tc_single_action(_exts) \ >> - (list_is_singular(&(_exts)->actions)) >> +#define tc_no_actions(_exts) (&(_exts)->nr_actions == 0) >> +#define tc_single_action(_exts) (&(_exts)->nr_actions == 1) > > Should remove the '&' here.

Re: [Patch net 5/5] net_sched: convert tcf_exts from list to flex_array

2016-08-09 Thread Amir Vadai
On Mon, Aug 8, 2016 at 11:46 PM, Cong Wang wrote: > As pointed out by Jamal, an action could be shared by > multiple filters, so we can't use list to chain them > any more after we get rid of the original tc_action. > Instead, we could just save pointers to these actions > in tcf_exts, since they

[Patch net 5/5] net_sched: convert tcf_exts from list to flex_array

2016-08-08 Thread Cong Wang
As pointed out by Jamal, an action could be shared by multiple filters, so we can't use list to chain them any more after we get rid of the original tc_action. Instead, we could just save pointers to these actions in tcf_exts, since they are refcount'ed, so convert the list to a flex array. The ug