Re: [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast

2018-01-29 Thread Cong Wang
On Mon, Jan 29, 2018 at 9:43 AM, David Miller wrote: > > Please follow up with John about making the queue allocation use > a prepare + commit phase. Will do it once net-next is re-open. > > And as for the TX queue state handling on change, I think it's > fine to purge the whole queue. That is

Re: [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast

2018-01-29 Thread David Miller
From: Cong Wang Date: Thu, 25 Jan 2018 18:26:21 -0800 > This pathcset restores the pfifo_fast qdisc behavior of dropping > packets based on latest dev->tx_queue_len. Patch 1 introduces > a helper, patch 2 introduces a new Qdisc ops which is called when > we modify tx_queue_len, patch 3 implements

Re: [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast

2018-01-28 Thread Cong Wang
On Sun, Jan 28, 2018 at 10:09 PM, John Fastabend wrote: > On 01/28/2018 09:57 PM, Cong Wang wrote: >> On Sun, Jan 28, 2018 at 9:35 PM, John Fastabend >> wrote: >>> On 01/25/2018 06:26 PM, Cong Wang wrote: This pathcset restores the pfifo_fast qdisc behavior of dropping packets based on

Re: [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast

2018-01-28 Thread John Fastabend
On 01/28/2018 09:57 PM, Cong Wang wrote: > On Sun, Jan 28, 2018 at 9:35 PM, John Fastabend > wrote: >> On 01/25/2018 06:26 PM, Cong Wang wrote: >>> This pathcset restores the pfifo_fast qdisc behavior of dropping >>> packets based on latest dev->tx_queue_len. Patch 1 introduces >>> a helper, patch

Re: [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast

2018-01-28 Thread Cong Wang
On Sun, Jan 28, 2018 at 9:35 PM, John Fastabend wrote: > We have time (its only in net-next) so lets do the complete fix > rather than this series IMO. Also have to remind you: this patchset fixes a regression introduced by your patchset in net-next, it is not a new feature. I don't think it is a

Re: [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast

2018-01-28 Thread Cong Wang
On Sun, Jan 28, 2018 at 9:35 PM, John Fastabend wrote: > On 01/25/2018 06:26 PM, Cong Wang wrote: >> This pathcset restores the pfifo_fast qdisc behavior of dropping >> packets based on latest dev->tx_queue_len. Patch 1 introduces >> a helper, patch 2 introduces a new Qdisc ops which is called whe

Re: [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast

2018-01-28 Thread John Fastabend
On 01/25/2018 06:26 PM, Cong Wang wrote: > This pathcset restores the pfifo_fast qdisc behavior of dropping > packets based on latest dev->tx_queue_len. Patch 1 introduces > a helper, patch 2 introduces a new Qdisc ops which is called when > we modify tx_queue_len, patch 3 implements this ops for p

[Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast

2018-01-25 Thread Cong Wang
This pathcset restores the pfifo_fast qdisc behavior of dropping packets based on latest dev->tx_queue_len. Patch 1 introduces a helper, patch 2 introduces a new Qdisc ops which is called when we modify tx_queue_len, patch 3 implements this ops for pfifo_fast. Please see each patch for details. -