Re: [Patch net-next v2 2/4] net_sched: update hierarchical backlog too

2015-11-02 Thread Cong Wang
On Mon, Nov 2, 2015 at 1:20 PM, Eric Dumazet wrote: > > Well, before your changes, the qdisc_tree_decrease_qlen(sch, 0) would > have been useless, since qdisc_tree_decrease_qlen() does nothing in this > case [1] > > But after your changes, we need to change the backlog, even if the qlen > does not

Re: [Patch net-next v2 2/4] net_sched: update hierarchical backlog too

2015-11-02 Thread Eric Dumazet
On Mon, 2015-11-02 at 13:09 -0800, Cong Wang wrote: > (Sorry for the delay) > > On Fri, Oct 30, 2015 at 12:30 PM, Eric Dumazet wrote: > > On Fri, 2015-10-30 at 11:22 -0700, Cong Wang wrote: > >> diff --git a/net/sched/sch_sfq.c b/net/sched/sch_sfq.c > >> index 3abab53..498f0a2 100644 > >> --- a/n

Re: [Patch net-next v2 2/4] net_sched: update hierarchical backlog too

2015-11-02 Thread Cong Wang
(Sorry for the delay) On Fri, Oct 30, 2015 at 12:30 PM, Eric Dumazet wrote: > On Fri, 2015-10-30 at 11:22 -0700, Cong Wang wrote: >> diff --git a/net/sched/sch_sfq.c b/net/sched/sch_sfq.c >> index 3abab53..498f0a2 100644 >> --- a/net/sched/sch_sfq.c >> +++ b/net/sched/sch_sfq.c >> @@ -346,7 +346,

Re: [Patch net-next v2 2/4] net_sched: update hierarchical backlog too

2015-10-30 Thread Eric Dumazet
On Fri, 2015-10-30 at 11:22 -0700, Cong Wang wrote: > When the bottom qdisc decides to, for example, drop some packet, > it calls qdisc_tree_decrease_qlen() to update the queue length > for all its ancestors, we need to update the backlog too to > keep the stats on root qdisc accurate. > > Cc: Jam

[Patch net-next v2 2/4] net_sched: update hierarchical backlog too

2015-10-30 Thread Cong Wang
When the bottom qdisc decides to, for example, drop some packet, it calls qdisc_tree_decrease_qlen() to update the queue length for all its ancestors, we need to update the backlog too to keep the stats on root qdisc accurate. Cc: Jamal Hadi Salim Acked-by: Jamal Hadi Salim Signed-off-by: Cong W