Re: [Patch net-next v2 2/2] net_sched: add network namespace support for tc actions

2016-02-25 Thread Jamal Hadi Salim
On 16-02-24 12:21 PM, Cong Wang wrote: On Wed, Feb 24, 2016 at 5:19 AM, Jamal Hadi Salim wrote: [..] Did you mean something else or am i missing the obvious? I am looking at the call sites for tcf_action_destroy(): -tc_dump_tfilter() has access to *net -tcf_exts_change() - one level lower it h

Re: [Patch net-next v2 2/2] net_sched: add network namespace support for tc actions

2016-02-24 Thread Cong Wang
On Tue, Feb 23, 2016 at 5:14 AM, Jamal Hadi Salim wrote: >> - int (*walk)(struct sk_buff *, struct netlink_callback *, int, >> struct tc_action *); >> + int (*walk)(struct net *, struct sk_buff *, >> + struct netlink_callback *, int, struct tc_action >> *)

Re: [Patch net-next v2 2/2] net_sched: add network namespace support for tc actions

2016-02-24 Thread Cong Wang
On Wed, Feb 24, 2016 at 5:19 AM, Jamal Hadi Salim wrote: > On 16-02-23 05:23 PM, Cong Wang wrote: >> >> On Tue, Feb 23, 2016 at 5:14 AM, Jamal Hadi Salim >> wrote: > > >>> It doesnt seem neccessary to have hinfo in tc_action. Quick scan: >>> __tcf_hash_release() seems to be the only other place t

Re: [Patch net-next v2 2/2] net_sched: add network namespace support for tc actions

2016-02-24 Thread Jamal Hadi Salim
On 16-02-23 05:23 PM, Cong Wang wrote: On Tue, Feb 23, 2016 at 5:14 AM, Jamal Hadi Salim wrote: It doesnt seem neccessary to have hinfo in tc_action. Quick scan: __tcf_hash_release() seems to be the only other place that uses it. And the callers to that appear capable of passing the struct ne

Re: [Patch net-next v2 2/2] net_sched: add network namespace support for tc actions

2016-02-23 Thread Cong Wang
On Tue, Feb 23, 2016 at 5:14 AM, Jamal Hadi Salim wrote: > On 16-02-22 06:57 PM, Cong Wang wrote: > > [..] > >> >> diff --git a/include/net/act_api.h b/include/net/act_api.h >> index 8c4e3ff..342be6c 100644 >> --- a/include/net/act_api.h >> +++ b/include/net/act_api.h >> @@ -7,6 +7,8 @@ >> >> #i

Re: [Patch net-next v2 2/2] net_sched: add network namespace support for tc actions

2016-02-23 Thread Jamal Hadi Salim
On 16-02-22 06:57 PM, Cong Wang wrote: [..] diff --git a/include/net/act_api.h b/include/net/act_api.h index 8c4e3ff..342be6c 100644 --- a/include/net/act_api.h +++ b/include/net/act_api.h @@ -7,6 +7,8 @@ #include #include +#include +#include struct tcf_common { struct hlis

[Patch net-next v2 2/2] net_sched: add network namespace support for tc actions

2016-02-22 Thread Cong Wang
Currently tc actions are stored in a per-module hashtable, therefore are visible to all network namespaces. This is probably the last part of the tc subsystem which is not aware of netns now. This patch makes them per-netns, several tc action API's need to be adjusted for this. The tc action API c