Re: [Patch net-next v2] ipv4: get rid of ip_ra_lock

2017-04-30 Thread David Miller
From: Cong Wang Date: Fri, 28 Apr 2017 10:04:29 -0700 > After commit 1215e51edad1 ("ipv4: fix a deadlock in ip_ra_control") > we always take RTNL lock for ip_ra_control() which is the only place > we update the list ip_ra_chain, so the ip_ra_lock is no longer needed. > > As Eric points out, BH d

Re: [Patch net-next v2] ipv4: get rid of ip_ra_lock

2017-04-30 Thread Eric Dumazet
On Fri, 2017-04-28 at 10:04 -0700, Cong Wang wrote: > After commit 1215e51edad1 ("ipv4: fix a deadlock in ip_ra_control") > we always take RTNL lock for ip_ra_control() which is the only place > we update the list ip_ra_chain, so the ip_ra_lock is no longer needed. > > As Eric points out, BH does

Re: [Patch net-next v2] ipv4: get rid of ip_ra_lock

2017-04-28 Thread Hannes Frederic Sowa
On 28.04.2017 19:04, Cong Wang wrote: > After commit 1215e51edad1 ("ipv4: fix a deadlock in ip_ra_control") > we always take RTNL lock for ip_ra_control() which is the only place > we update the list ip_ra_chain, so the ip_ra_lock is no longer needed. > > As Eric points out, BH does not need to di

[Patch net-next v2] ipv4: get rid of ip_ra_lock

2017-04-28 Thread Cong Wang
After commit 1215e51edad1 ("ipv4: fix a deadlock in ip_ra_control") we always take RTNL lock for ip_ra_control() which is the only place we update the list ip_ra_chain, so the ip_ra_lock is no longer needed. As Eric points out, BH does not need to disable either, RCU readers don't care. Signed-of