Re: [Patch net-next v2] act_mirred: get rid of tcfm_ifindex from struct tcf_mirred

2017-12-06 Thread David Miller
From: Cong Wang Date: Tue, 5 Dec 2017 16:17:26 -0800 > tcfm_dev always points to the correct netdev and we already > hold a refcnt, so no need to use tcfm_ifindex to lookup again. > > If we would support moving target netdev across netns, using > pointer would be better than ifindex. > > This

Re: [Patch net-next v2] act_mirred: get rid of tcfm_ifindex from struct tcf_mirred

2017-12-06 Thread Jiri Pirko
Wed, Dec 06, 2017 at 01:17:26AM CET, xiyou.wangc...@gmail.com wrote: >tcfm_dev always points to the correct netdev and we already >hold a refcnt, so no need to use tcfm_ifindex to lookup again. > >If we would support moving target netdev across netns, using >pointer would be better than ifindex. >

[Patch net-next v2] act_mirred: get rid of tcfm_ifindex from struct tcf_mirred

2017-12-05 Thread Cong Wang
tcfm_dev always points to the correct netdev and we already hold a refcnt, so no need to use tcfm_ifindex to lookup again. If we would support moving target netdev across netns, using pointer would be better than ifindex. This also fixes dumping obsolete ifindex, now after the target device is go