Re: [Patch net-next 1/4] net_sched: introduce qdisc_replace() helper

2015-10-16 Thread Jamal Hadi Salim
On 10/15/15 00:15, Cong Wang wrote: On Wed, Oct 14, 2015 at 4:56 AM, Jamal Hadi Salim wrote: On 10/12/15 14:38, Cong Wang wrote: Remove nearly duplicated code and prepare for the following patch. Cong - like Dave, I dont see equivalence in some of these changes. Example not sure how the q

Re: [Patch net-next 1/4] net_sched: introduce qdisc_replace() helper

2015-10-14 Thread Cong Wang
On Wed, Oct 14, 2015 at 4:56 AM, Jamal Hadi Salim wrote: > On 10/12/15 14:38, Cong Wang wrote: >> >> Remove nearly duplicated code and prepare for the following patch. >> > > > Cong - like Dave, I dont see equivalence in some of these > changes. > Example not sure how the qfq grafting invocation o

Re: [Patch net-next 1/4] net_sched: introduce qdisc_replace() helper

2015-10-14 Thread Cong Wang
On Tue, Oct 13, 2015 at 6:54 PM, David Miller wrote: > From: Cong Wang > Date: Mon, 12 Oct 2015 11:38:00 -0700 > >> Remove nearly duplicated code and prepare for the following patch. >> >> Cc: Jamal Hadi Salim >> Signed-off-by: Cong Wang > > This isn't an equivalent transformation: > >> +static

Re: [Patch net-next 1/4] net_sched: introduce qdisc_replace() helper

2015-10-14 Thread Jamal Hadi Salim
On 10/12/15 14:38, Cong Wang wrote: Remove nearly duplicated code and prepare for the following patch. Cong - like Dave, I dont see equivalence in some of these changes. Example not sure how the qfq grafting invocation of qfq_purge_queue fits in. There are a few others. cheers, jamal -- To

Re: [Patch net-next 1/4] net_sched: introduce qdisc_replace() helper

2015-10-13 Thread David Miller
From: Cong Wang Date: Mon, 12 Oct 2015 11:38:00 -0700 > Remove nearly duplicated code and prepare for the following patch. > > Cc: Jamal Hadi Salim > Signed-off-by: Cong Wang This isn't an equivalent transformation: > +static inline struct Qdisc *qdisc_replace(struct Qdisc *sch, struct Qdisc

[Patch net-next 1/4] net_sched: introduce qdisc_replace() helper

2015-10-12 Thread Cong Wang
Remove nearly duplicated code and prepare for the following patch. Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- include/net/sch_generic.h | 17 + net/sched/sch_cbq.c | 7 +-- net/sched/sch_drr.c | 6 +- net/sched/sch_dsmark.c| 8 +--- net/sche