Re: [Patch net-next 1/3] net: introduce helper dev_change_tx_queue_len()

2018-01-21 Thread John Fastabend
On 01/19/2018 03:09 PM, Cong Wang wrote: > This patch promotes the local change_tx_queue_len() to a core > helper function, dev_change_tx_queue_len(), so that rtnetlink > and net-sysfs could share the code. This also prepares for the > following patch. > > Note, the -EFAULT in the original code do

Re: [Patch net-next 1/3] net: introduce helper dev_change_tx_queue_len()

2018-01-21 Thread Cong Wang
On Sat, Jan 20, 2018 at 8:52 PM, John Fastabend wrote: > On 01/19/2018 03:09 PM, Cong Wang wrote: >> This patch promotes the local change_tx_queue_len() to a core >> helper function, dev_change_tx_queue_len(), so that rtnetlink >> and net-sysfs could share the code. This also prepares for the >> f

Re: [Patch net-next 1/3] net: introduce helper dev_change_tx_queue_len()

2018-01-20 Thread John Fastabend
On 01/19/2018 03:09 PM, Cong Wang wrote: > This patch promotes the local change_tx_queue_len() to a core > helper function, dev_change_tx_queue_len(), so that rtnetlink > and net-sysfs could share the code. This also prepares for the > following patch. > > Note, the -EFAULT in the original code do

[Patch net-next 1/3] net: introduce helper dev_change_tx_queue_len()

2018-01-19 Thread Cong Wang
This patch promotes the local change_tx_queue_len() to a core helper function, dev_change_tx_queue_len(), so that rtnetlink and net-sysfs could share the code. This also prepares for the following patch. Note, the -EFAULT in the original code doesn't make sense, we should propagate the errno from