Re: [Patch net-next 1/2] net_sched: move tc_action into tcf_common

2016-07-21 Thread Cong Wang
On Thu, Jul 21, 2016 at 11:35 AM, kbuild test robot wrote: > All warnings (new ones prefixed by >>): > >In file included from include/net/act_api.h:8:0, > from net/sched/act_police.c:22: >net/sched/act_police.c: In function 'tcf_act_police_init': >>> include/net/sch_gen

Re: [Patch net-next 1/2] net_sched: move tc_action into tcf_common

2016-07-21 Thread kbuild test robot
Hi, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Cong-Wang/net_sched-refactor-tc-action-structures/20160722-010949 config: sh-titan_defconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609 reproduce: wget

Re: [Patch net-next 1/2] net_sched: move tc_action into tcf_common

2016-07-21 Thread Cong Wang
On Thu, Jul 21, 2016 at 12:38 AM, Jamal Hadi Salim wrote: > It is an involved change (and i was fond of the container_of() > trickery;)). > > Looking at this patch I cant grok some parts - maybe i need to apply it > when i am not in a hurry to see clearly. > Mostly this around things like: > --- >

Re: [Patch net-next 1/2] net_sched: move tc_action into tcf_common

2016-07-21 Thread Jamal Hadi Salim
It is an involved change (and i was fond of the container_of() trickery;)). Looking at this patch I cant grok some parts - maybe i need to apply it when i am not in a hurry to see clearly. Mostly this around things like: --- const struct tc_action *a struct tcf_mirred *m = to_mirred(a) --- Essen

[Patch net-next 1/2] net_sched: move tc_action into tcf_common

2016-07-20 Thread Cong Wang
struct tc_action is confusing, currently we use it for two purposes: 1) Pass in arguments and carry out results from helper functions 2) A generic representation for tc actions The first one is error-prone, since we need to make sure we don't miss anything. This patch aims to get rid of this use,