Sat, Dec 02, 2017 at 08:53:20PM CET, xiyou.wangc...@gmail.com wrote:
>On Sat, Dec 2, 2017 at 11:47 AM, Cong Wang wrote:
>> On Sat, Dec 2, 2017 at 12:57 AM, Jiri Pirko wrote:
>>> Good. Please also use m->tcfm_dev->ifindex in tcf_mirred_dump and
>>> tcf_mirred_ifindex. Then you can remove tcfm_ifin
On Sat, Dec 2, 2017 at 11:47 AM, Cong Wang wrote:
> On Sat, Dec 2, 2017 at 12:57 AM, Jiri Pirko wrote:
>> Good. Please also use m->tcfm_dev->ifindex in tcf_mirred_dump and
>> tcf_mirred_ifindex. Then you can remove tcfm_ifindex completely.
>
> Sounds good. Will send v2.
Hold on, m->tcfm_dev coul
On Sat, Dec 2, 2017 at 12:57 AM, Jiri Pirko wrote:
> Good. Please also use m->tcfm_dev->ifindex in tcf_mirred_dump and
> tcf_mirred_ifindex. Then you can remove tcfm_ifindex completely.
Sounds good. Will send v2.
Thu, Nov 30, 2017 at 11:53:32PM CET, xiyou.wangc...@gmail.com wrote:
>tcfm_dev always points to the correct netdev and we already
>hold a refcnt, so no need to use ifindex to lookup again.
>
>If we would support moving target netdev across netns, using
>pointer would be better than ifindex.
>
>Cc:
Fri, Dec 01, 2017 at 10:46:42PM CET, xiyou.wangc...@gmail.com wrote:
>On Fri, Dec 1, 2017 at 9:56 AM, Jiri Pirko wrote:
>>
>> Isn't this here so user may specify a ifindex of netdev which is not yet
>> present on the system (not sure how much sense that would make though...)
>
>How is this even po
On Fri, Dec 1, 2017 at 9:56 AM, Jiri Pirko wrote:
>
> Isn't this here so user may specify a ifindex of netdev which is not yet
> present on the system (not sure how much sense that would make though...)
How is this even possible? If an ifindex is not present, we return ENODEV:
if (parm->
Thu, Nov 30, 2017 at 11:53:32PM CET, xiyou.wangc...@gmail.com wrote:
>tcfm_dev always points to the correct netdev and we already
>hold a refcnt, so no need to use ifindex to lookup again.
>
>If we would support moving target netdev across netns, using
>pointer would be better than ifindex.
>
>Cc:
tcfm_dev always points to the correct netdev and we already
hold a refcnt, so no need to use ifindex to lookup again.
If we would support moving target netdev across netns, using
pointer would be better than ifindex.
Cc: Jiri Pirko
Cc: Jamal Hadi Salim
Signed-off-by: Cong Wang
---
include/net
