Re: [Patch net] tipc: compare remote and local protocols in tipc_udp_enable()

2018-12-14 Thread David Miller
From: Cong Wang Date: Mon, 10 Dec 2018 15:23:30 -0800 > When TIPC_NLA_UDP_REMOTE is an IPv6 mcast address but > TIPC_NLA_UDP_LOCAL is an IPv4 address, a NULL-ptr deref is triggered > as the UDP tunnel sock is initialized to IPv4 or IPv6 sock merely > based on the protocol in local address. > > W

RE: [Patch net] tipc: compare remote and local protocols in tipc_udp_enable()

2018-12-12 Thread Jon Maloy
> -Original Message- > From: Cong Wang > Sent: 10-Dec-18 18:24 > To: netdev@vger.kernel.org > Cc: Cong Wang ; Ying Xue > ; Jon Maloy > Subject: [Patch net] tipc: compare remote and local protocols in > tipc_udp_enable() > > When TIPC_NLA_UDP_REMOT

[Patch net] tipc: compare remote and local protocols in tipc_udp_enable()

2018-12-10 Thread Cong Wang
When TIPC_NLA_UDP_REMOTE is an IPv6 mcast address but TIPC_NLA_UDP_LOCAL is an IPv4 address, a NULL-ptr deref is triggered as the UDP tunnel sock is initialized to IPv4 or IPv6 sock merely based on the protocol in local address. We should just error out when the remote address and local address ha