Re: [Patch net] net_sched: invoke ->attach() after setting dev->qdisc

2015-05-27 Thread David Miller
From: Cong Wang Date: Tue, 26 May 2015 16:08:48 -0700 > For mq qdisc, we add per tx queue qdisc to root qdisc > for display purpose, however, that happens too early, > before the new dev->qdisc is finally set, this causes > q->list points to an old root qdisc which is going to be > freed right be

Re: [Patch net] net_sched: invoke ->attach() after setting dev->qdisc

2015-05-26 Thread Eric Dumazet
On Tue, 2015-05-26 at 16:08 -0700, Cong Wang wrote: > For mq qdisc, we add per tx queue qdisc to root qdisc > for display purpose, however, that happens too early, > before the new dev->qdisc is finally set, this causes > q->list points to an old root qdisc which is going to be > freed right before

[Patch net] net_sched: invoke ->attach() after setting dev->qdisc

2015-05-26 Thread Cong Wang
For mq qdisc, we add per tx queue qdisc to root qdisc for display purpose, however, that happens too early, before the new dev->qdisc is finally set, this causes q->list points to an old root qdisc which is going to be freed right before assigning with a new one. Fix this by moving ->attach() afte