Re: [Patch net] net_sched: fix backward compatibility for TCA_KIND

2019-10-08 Thread Jakub Kicinski
On Mon, 7 Oct 2019 13:26:28 -0700, Cong Wang wrote: > Marcelo noticed a backward compatibility issue of TCA_KIND > after we move from NLA_STRING to NLA_NUL_STRING, so it is probably > too late to change it. > > Instead, to make everyone happy, we can just insert a NUL to > terminate the string wi

Re: [Patch net] net_sched: fix backward compatibility for TCA_KIND

2019-10-08 Thread Marcelo Ricardo Leitner
On Mon, Oct 07, 2019 at 01:26:28PM -0700, Cong Wang wrote: > Marcelo noticed a backward compatibility issue of TCA_KIND > after we move from NLA_STRING to NLA_NUL_STRING, so it is probably > too late to change it. > > Instead, to make everyone happy, we can just insert a NUL to > terminate the str

[Patch net] net_sched: fix backward compatibility for TCA_KIND

2019-10-07 Thread Cong Wang
Marcelo noticed a backward compatibility issue of TCA_KIND after we move from NLA_STRING to NLA_NUL_STRING, so it is probably too late to change it. Instead, to make everyone happy, we can just insert a NUL to terminate the string with nla_strlcpy() like we do for TC actions. Fixes: 62794fc4fbf5