Re: [Patch net] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-06 Thread Michal Kubecek
On Wed, May 06, 2020 at 12:08:35PM -0700, Cong Wang wrote: > On Tue, May 5, 2020 at 10:26 PM Michal Kubecek wrote: > > > > On Tue, May 05, 2020 at 03:35:27PM -0700, Cong Wang wrote: > > > On Tue, May 5, 2020 at 3:27 PM Michal Kubecek wrote: > > > > On Tue, May 05, 2020 at 02:58:19PM -0700, Cong W

Re: [Patch net] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-06 Thread Cong Wang
On Tue, May 5, 2020 at 10:26 PM Michal Kubecek wrote: > > On Tue, May 05, 2020 at 03:35:27PM -0700, Cong Wang wrote: > > On Tue, May 5, 2020 at 3:27 PM Michal Kubecek wrote: > > > On Tue, May 05, 2020 at 02:58:19PM -0700, Cong Wang wrote: > > > > diff --git a/net/core/dev.c b/net/core/dev.c > > >

Re: [Patch net] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-06 Thread Cong Wang
On Wed, May 6, 2020 at 11:46 AM Cong Wang wrote: > > On Tue, May 5, 2020 at 3:42 PM Jay Vosburgh > wrote: > > > > Cong Wang wrote: > > > > >syzbot managed to trigger a recursive NETDEV_FEAT_CHANGE event > > >between bonding master and slave. I managed to find a reproducer > > >for this: > > > >

Re: [Patch net] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-06 Thread Cong Wang
On Tue, May 5, 2020 at 3:42 PM Jay Vosburgh wrote: > > Cong Wang wrote: > > >syzbot managed to trigger a recursive NETDEV_FEAT_CHANGE event > >between bonding master and slave. I managed to find a reproducer > >for this: > > > > ip li set bond0 up > > ifenslave bond0 eth0 > > brctl addbr br0 >

Re: [Patch net] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-05 Thread Michal Kubecek
On Tue, May 05, 2020 at 03:35:27PM -0700, Cong Wang wrote: > On Tue, May 5, 2020 at 3:27 PM Michal Kubecek wrote: > > On Tue, May 05, 2020 at 02:58:19PM -0700, Cong Wang wrote: > > > diff --git a/net/core/dev.c b/net/core/dev.c > > > index 522288177bbd..ece50ae346c3 100644 > > > --- a/net/core/dev

Re: [Patch net] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-05 Thread Jay Vosburgh
Cong Wang wrote: >syzbot managed to trigger a recursive NETDEV_FEAT_CHANGE event >between bonding master and slave. I managed to find a reproducer >for this: > > ip li set bond0 up > ifenslave bond0 eth0 > brctl addbr br0 > ethtool -K eth0 lro off > brctl addif br0 bond0 > ip li set br0 up

Re: [Patch net] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-05 Thread Cong Wang
On Tue, May 5, 2020 at 3:27 PM Michal Kubecek wrote: > > On Tue, May 05, 2020 at 02:58:19PM -0700, Cong Wang wrote: > > syzbot managed to trigger a recursive NETDEV_FEAT_CHANGE event > > between bonding master and slave. I managed to find a reproducer > > for this: > > > > ip li set bond0 up > >

Re: [Patch net] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-05 Thread Michal Kubecek
On Tue, May 05, 2020 at 02:58:19PM -0700, Cong Wang wrote: > syzbot managed to trigger a recursive NETDEV_FEAT_CHANGE event > between bonding master and slave. I managed to find a reproducer > for this: > > ip li set bond0 up > ifenslave bond0 eth0 > brctl addbr br0 > ethtool -K eth0 lro o

[Patch net] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-05 Thread Cong Wang
syzbot managed to trigger a recursive NETDEV_FEAT_CHANGE event between bonding master and slave. I managed to find a reproducer for this: ip li set bond0 up ifenslave bond0 eth0 brctl addbr br0 ethtool -K eth0 lro off brctl addif br0 bond0 ip li set br0 up When a NETDEV_FEAT_CHANGE ev