Re: [Patch net] ipv6: initialize route null entry in addrconf_init()

2017-05-04 Thread Cong Wang
On Thu, May 4, 2017 at 10:12 AM, David Ahern wrote: > On 5/4/17 10:51 AM, David Miller wrote: >> From: Andrey Konovalov >> Date: Thu, 4 May 2017 14:28:37 +0200 >> >>> On Thu, May 4, 2017 at 7:07 AM, Cong Wang wrote: Andrey reported a crash on init_net.ipv6.ip6_null_entry->rt6i_idev sin

Re: [Patch net] ipv6: initialize route null entry in addrconf_init()

2017-05-04 Thread David Ahern
On 5/4/17 10:51 AM, David Miller wrote: > From: Andrey Konovalov > Date: Thu, 4 May 2017 14:28:37 +0200 > >> On Thu, May 4, 2017 at 7:07 AM, Cong Wang wrote: >>> Andrey reported a crash on init_net.ipv6.ip6_null_entry->rt6i_idev >>> since it is always NULL. >>> >>> This is clearly wrong, we have

Re: [Patch net] ipv6: initialize route null entry in addrconf_init()

2017-05-04 Thread David Miller
From: Andrey Konovalov Date: Thu, 4 May 2017 14:28:37 +0200 > On Thu, May 4, 2017 at 7:07 AM, Cong Wang wrote: >> Andrey reported a crash on init_net.ipv6.ip6_null_entry->rt6i_idev >> since it is always NULL. >> >> This is clearly wrong, we have code to initialize it to loopback_dev, >> unfortun

Re: [Patch net] ipv6: initialize route null entry in addrconf_init()

2017-05-04 Thread Andrey Konovalov
On Thu, May 4, 2017 at 7:07 AM, Cong Wang wrote: > Andrey reported a crash on init_net.ipv6.ip6_null_entry->rt6i_idev > since it is always NULL. > > This is clearly wrong, we have code to initialize it to loopback_dev, > unfortunately the order is still not correct. > > loopback_dev is registered

[Patch net] ipv6: initialize route null entry in addrconf_init()

2017-05-03 Thread Cong Wang
Andrey reported a crash on init_net.ipv6.ip6_null_entry->rt6i_idev since it is always NULL. This is clearly wrong, we have code to initialize it to loopback_dev, unfortunately the order is still not correct. loopback_dev is registered very early during boot, we lose a chance to re-initialize it i