Re: [Patch net] ipv6: fix double refcount of fib6_metrics

2018-08-12 Thread David Ahern
On 8/3/18 12:20 AM, Cong Wang wrote: > All the callers of ip6_rt_copy_init()/rt6_set_from() hold refcnt > of the "from" fib6_info, so there is no need to hold fib6_metrics > refcnt again, because fib6_metrics refcnt is only released when > fib6_info is gone, that is, they have the same life time, s

Re: [Patch net] ipv6: fix double refcount of fib6_metrics

2018-08-05 Thread David Miller
From: Cong Wang Date: Thu, 2 Aug 2018 23:20:38 -0700 > All the callers of ip6_rt_copy_init()/rt6_set_from() hold refcnt > of the "from" fib6_info, so there is no need to hold fib6_metrics > refcnt again, because fib6_metrics refcnt is only released when > fib6_info is gone, that is, they have th

Re: [Patch net] ipv6: fix double refcount of fib6_metrics

2018-08-03 Thread David Miller
From: Cong Wang Date: Thu, 2 Aug 2018 23:20:38 -0700 > All the callers of ip6_rt_copy_init()/rt6_set_from() hold refcnt > of the "from" fib6_info, so there is no need to hold fib6_metrics > refcnt again, because fib6_metrics refcnt is only released when > fib6_info is gone, that is, they have th

[Patch net] ipv6: fix double refcount of fib6_metrics

2018-08-02 Thread Cong Wang
All the callers of ip6_rt_copy_init()/rt6_set_from() hold refcnt of the "from" fib6_info, so there is no need to hold fib6_metrics refcnt again, because fib6_metrics refcnt is only released when fib6_info is gone, that is, they have the same life time, so the whole fib6_metrics refcnt can be remove