On Wed, 2015-04-22 at 10:45 -0700, Cong Wang wrote:
> The second parameter of eth_get_headlen() is the length of
> the frame buffer, not the header length of skb.
>
> Cc: Jeff Kirsher
> Signed-off-by: Cong Wang
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 4 +++-
> 1 file changed, 3 inse
On Thu, Apr 23, 2015 at 12:45 PM, Alexander Duyck
wrote:
> On 04/23/2015 12:30 PM, Cong Wang wrote:
>>
>> (Off-topic...)
>>
>> On Wed, Apr 22, 2015 at 4:23 PM, Cong Wang wrote:
>>>
>>> The code looks correct to me now, except it is suspicious skb->len
>>> is not updated after skb_copy_to_linear_d
On 04/23/2015 12:30 PM, Cong Wang wrote:
(Off-topic...)
On Wed, Apr 22, 2015 at 4:23 PM, Cong Wang wrote:
The code looks correct to me now, except it is suspicious skb->len
is not updated after skb_copy_to_linear_data() while skb->tail is
advanced already. I need to think more before submittin
(Off-topic...)
On Wed, Apr 22, 2015 at 4:23 PM, Cong Wang wrote:
>
> The code looks correct to me now, except it is suspicious skb->len
> is not updated after skb_copy_to_linear_data() while skb->tail is
> advanced already. I need to think more before submitting a patch.
I feel like we need the
On Thu, Apr 23, 2015 at 11:40 AM, Alexander Duyck
wrote:
> On 04/23/2015 11:06 AM, Cong Wang wrote:
>> On Wed, Apr 22, 2015 at 8:40 PM, Alexander Duyck
>> wrote:
>>> On 04/22/2015 04:23 PM, Cong Wang wrote:
On Wed, Apr 22, 2015 at 3:34 PM, Alexander Duyck
wrote:
> On 04/22/2015 02:
On 04/23/2015 11:06 AM, Cong Wang wrote:
> On Wed, Apr 22, 2015 at 8:40 PM, Alexander Duyck
> wrote:
>> On 04/22/2015 04:23 PM, Cong Wang wrote:
>>> On Wed, Apr 22, 2015 at 3:34 PM, Alexander Duyck
>>> wrote:
On 04/22/2015 02:56 PM, Cong Wang wrote:
> On Wed, Apr 22, 2015 at 2:42 PM, Ale
On Wed, Apr 22, 2015 at 8:40 PM, Alexander Duyck
wrote:
> On 04/22/2015 04:23 PM, Cong Wang wrote:
>> On Wed, Apr 22, 2015 at 3:34 PM, Alexander Duyck
>> wrote:
>>> On 04/22/2015 02:56 PM, Cong Wang wrote:
On Wed, Apr 22, 2015 at 2:42 PM, Alexander Duyck
wrote:
> On 04/22/2015 01:3
On 04/22/2015 04:23 PM, Cong Wang wrote:
> On Wed, Apr 22, 2015 at 3:34 PM, Alexander Duyck
> wrote:
>> On 04/22/2015 02:56 PM, Cong Wang wrote:
>>> On Wed, Apr 22, 2015 at 2:42 PM, Alexander Duyck
>>> wrote:
On 04/22/2015 01:33 PM, Cong Wang wrote:
> First, make sure you don't miss the
On Wed, Apr 22, 2015 at 3:34 PM, Alexander Duyck
wrote:
> On 04/22/2015 02:56 PM, Cong Wang wrote:
>> On Wed, Apr 22, 2015 at 2:42 PM, Alexander Duyck
>> wrote:
>>> On 04/22/2015 01:33 PM, Cong Wang wrote:
First, make sure you don't miss the TSIP case right above:
The frag starting
On 04/22/2015 02:56 PM, Cong Wang wrote:
> On Wed, Apr 22, 2015 at 2:42 PM, Alexander Duyck
> wrote:
>> On 04/22/2015 01:33 PM, Cong Wang wrote:
>>> First, make sure you don't miss the TSIP case right above:
>>>
>>> The frag starting pointer and its size are advanced by:
>>>
>>> skb_frag_size_sub(
On Wed, Apr 22, 2015 at 2:42 PM, Alexander Duyck
wrote:
> On 04/22/2015 01:33 PM, Cong Wang wrote:
>> First, make sure you don't miss the TSIP case right above:
>>
>> The frag starting pointer and its size are advanced by:
>>
>> skb_frag_size_sub(frag, IGB_TS_HDR_LEN);
>> ...
>> va += IGB_TS_HDR_L
On 04/22/2015 01:33 PM, Cong Wang wrote:
> On Wed, Apr 22, 2015 at 1:21 PM, Alexander Duyck
> wrote:
>> On 04/22/2015 01:14 PM, Cong Wang wrote:
>>> On Wed, Apr 22, 2015 at 12:43 PM, Alexander Duyck
>>> wrote:
On 04/22/2015 10:45 AM, Cong Wang wrote:
> The second parameter of eth_get_hea
On Wed, Apr 22, 2015 at 1:21 PM, Alexander Duyck
wrote:
> On 04/22/2015 01:14 PM, Cong Wang wrote:
>> On Wed, Apr 22, 2015 at 12:43 PM, Alexander Duyck
>> wrote:
>>> On 04/22/2015 10:45 AM, Cong Wang wrote:
The second parameter of eth_get_headlen() is the length of
the frame buffer, not
On 04/22/2015 01:14 PM, Cong Wang wrote:
> On Wed, Apr 22, 2015 at 12:43 PM, Alexander Duyck
> wrote:
>> On 04/22/2015 10:45 AM, Cong Wang wrote:
>>> The second parameter of eth_get_headlen() is the length of
>>> the frame buffer, not the header length of skb.
>>>
>>> Cc: Jeff Kirsher
>>> Signed-
On Wed, Apr 22, 2015 at 12:43 PM, Alexander Duyck
wrote:
> On 04/22/2015 10:45 AM, Cong Wang wrote:
>> The second parameter of eth_get_headlen() is the length of
>> the frame buffer, not the header length of skb.
>>
>> Cc: Jeff Kirsher
>> Signed-off-by: Cong Wang
>> ---
>> drivers/net/ethernet/
On 04/22/2015 10:45 AM, Cong Wang wrote:
> The second parameter of eth_get_headlen() is the length of
> the frame buffer, not the header length of skb.
>
> Cc: Jeff Kirsher
> Signed-off-by: Cong Wang
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1
The second parameter of eth_get_headlen() is the length of
the frame buffer, not the header length of skb.
Cc: Jeff Kirsher
Signed-off-by: Cong Wang
---
drivers/net/ethernet/intel/igb/igb_main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ig
17 matches
Mail list logo
