Re: [Patch iproute2] tc: add performance counters for basic filter

2019-01-23 Thread Cong Wang
On Wed, Jan 23, 2019 at 12:43 PM Stephen Hemminger wrote: > > On Tue, 22 Jan 2019 22:41:45 -0800 > Cong Wang wrote: > > > + if (tb[TCA_BASIC_PCNT]) { > > + if (RTA_PAYLOAD(tb[TCA_BASIC_PCNT]) < sizeof(*pf)) { > > + fprintf(f, "Broken perf counters\n"); > > +

Re: [Patch iproute2] tc: add performance counters for basic filter

2019-01-23 Thread Stephen Hemminger
On Tue, 22 Jan 2019 22:41:45 -0800 Cong Wang wrote: > + if (tb[TCA_BASIC_PCNT]) { > + if (RTA_PAYLOAD(tb[TCA_BASIC_PCNT]) < sizeof(*pf)) { > + fprintf(f, "Broken perf counters\n"); > + return -1; Errors should go to stderr not f (which is

[Patch iproute2] tc: add performance counters for basic filter

2019-01-22 Thread Cong Wang
Sample output: filter protocol arp pref 49152 basic chain 0 filter protocol arp pref 49152 basic chain 0 handle 0x1 (rule hit 3 success 3) action order 1: gact action pass random type none pass val 0 index 1 ref 1 bind 1 installed 81 sec used 4 sec Action statistics: Sent 12