Re: [Patch iproute2] tc: add hit counter for matchall

2019-01-23 Thread Cong Wang
On Wed, Jan 23, 2019 at 12:47 PM Stephen Hemminger wrote: > > On Thu, 17 Jan 2019 13:18:55 -0800 > Cong Wang wrote: > > > > > + if (tb[TCA_MATCHALL_PCNT]) { > > + if (RTA_PAYLOAD(tb[TCA_MATCHALL_PCNT]) < sizeof(*pf)) { > > + print_string(PRINT_FP, NULL, "Broke

Re: [Patch iproute2] tc: add hit counter for matchall

2019-01-23 Thread Stephen Hemminger
On Thu, 17 Jan 2019 13:18:55 -0800 Cong Wang wrote: > > + if (tb[TCA_MATCHALL_PCNT]) { > + if (RTA_PAYLOAD(tb[TCA_MATCHALL_PCNT]) < sizeof(*pf)) { > + print_string(PRINT_FP, NULL, "Broken perf counters\n", > NULL); This the wrong way to print an error mess

Re: [Patch iproute2] tc: add hit counter for matchall

2019-01-22 Thread Cong Wang
On Mon, Jan 21, 2019 at 8:35 AM David Ahern wrote: > > On 1/17/19 2:18 PM, Cong Wang wrote: > > Cc: Martin Olsson > > Cc: Jamal Hadi Salim > > Cc: Jiri Pirko > > Cc: David Ahern > > Signed-off-by: Cong Wang > > --- > > tc/f_matchall.c | 14 ++ > > 1 file changed, 14 insertions(+)

Re: [Patch iproute2] tc: add hit counter for matchall

2019-01-21 Thread David Ahern
On 1/17/19 2:18 PM, Cong Wang wrote: > Cc: Martin Olsson > Cc: Jamal Hadi Salim > Cc: Jiri Pirko > Cc: David Ahern > Signed-off-by: Cong Wang > --- > tc/f_matchall.c | 14 ++ > 1 file changed, 14 insertions(+) > applied to iproute2-next. In the future, add some kind of descript

[Patch iproute2] tc: add hit counter for matchall

2019-01-17 Thread Cong Wang
Cc: Martin Olsson Cc: Jamal Hadi Salim Cc: Jiri Pirko Cc: David Ahern Signed-off-by: Cong Wang --- tc/f_matchall.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tc/f_matchall.c b/tc/f_matchall.c index 5ebd0415..03dd51de 100644 --- a/tc/f_matchall.c +++ b/tc/f_matchall.c