Re: [Patch bpf-next v7 09/13] udp: implement ->read_sock() for sockmap

2021-03-29 Thread John Fastabend
Cong Wang wrote: > On Mon, Mar 29, 2021 at 11:23 PM John Fastabend > wrote: > > > > Cong Wang wrote: > > > On Mon, Mar 29, 2021 at 1:54 PM John Fastabend > > > wrote: > > > > > > > > Cong Wang wrote: > > > > > From: Cong Wang > > > > > > > > > > This is similar to tcp_read_sock(), except we do

Re: [Patch bpf-next v7 09/13] udp: implement ->read_sock() for sockmap

2021-03-29 Thread Cong Wang
On Mon, Mar 29, 2021 at 11:23 PM John Fastabend wrote: > > Cong Wang wrote: > > On Mon, Mar 29, 2021 at 1:54 PM John Fastabend > > wrote: > > > > > > Cong Wang wrote: > > > > From: Cong Wang > > > > > > > > This is similar to tcp_read_sock(), except we do not need > > > > to worry about connect

Re: [Patch bpf-next v7 09/13] udp: implement ->read_sock() for sockmap

2021-03-29 Thread John Fastabend
Cong Wang wrote: > On Mon, Mar 29, 2021 at 1:54 PM John Fastabend > wrote: > > > > Cong Wang wrote: > > > From: Cong Wang > > > > > > This is similar to tcp_read_sock(), except we do not need > > > to worry about connections, we just need to retrieve skb > > > from UDP receive queue. > > > > > >

Re: [Patch bpf-next v7 09/13] udp: implement ->read_sock() for sockmap

2021-03-29 Thread Cong Wang
On Mon, Mar 29, 2021 at 1:54 PM John Fastabend wrote: > > Cong Wang wrote: > > From: Cong Wang > > > > This is similar to tcp_read_sock(), except we do not need > > to worry about connections, we just need to retrieve skb > > from UDP receive queue. > > > > Note, the return value of ->read_sock()

RE: [Patch bpf-next v7 09/13] udp: implement ->read_sock() for sockmap

2021-03-29 Thread John Fastabend
Cong Wang wrote: > From: Cong Wang > > This is similar to tcp_read_sock(), except we do not need > to worry about connections, we just need to retrieve skb > from UDP receive queue. > > Note, the return value of ->read_sock() is unused in > sk_psock_verdict_data_ready(). > > Cc: John Fastabend

[Patch bpf-next v7 09/13] udp: implement ->read_sock() for sockmap

2021-03-28 Thread Cong Wang
From: Cong Wang This is similar to tcp_read_sock(), except we do not need to worry about connections, we just need to retrieve skb from UDP receive queue. Note, the return value of ->read_sock() is unused in sk_psock_verdict_data_ready(). Cc: John Fastabend Cc: Daniel Borkmann Cc: Jakub Sitni