Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-18 Thread Andrii Nakryiko
On Thu, Dec 17, 2020 at 1:14 PM Cong Wang wrote: > > On Wed, Dec 16, 2020 at 10:29 PM Cong Wang wrote: > > > > On Wed, Dec 16, 2020 at 10:35 AM Andrii Nakryiko > > wrote: > > > Minimize duplication of the code, no one said copy/paste all the code. > > > But memory bloat is a real problem and sho

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-18 Thread Andrii Nakryiko
On Wed, Dec 16, 2020 at 10:29 PM Cong Wang wrote: > > On Wed, Dec 16, 2020 at 10:35 AM Andrii Nakryiko > wrote: > > > > On Tue, Dec 15, 2020 at 4:15 PM Cong Wang wrote: > > > > > > On Tue, Dec 15, 2020 at 2:08 PM Andrii Nakryiko > > > wrote: > > > > > > > > On Tue, Dec 15, 2020 at 12:06 PM Cong

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-17 Thread Daniel Borkmann
On 12/16/20 1:22 AM, Cong Wang wrote: On Tue, Dec 15, 2020 at 3:23 PM Daniel Borkmann wrote: On 12/15/20 11:03 PM, Andrii Nakryiko wrote: On Tue, Dec 15, 2020 at 12:06 PM Cong Wang wrote: On Tue, Dec 15, 2020 at 11:27 AM Andrii Nakryiko wrote: On Mon, Dec 14, 2020 at 12:17 PM Cong Wang

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-17 Thread Cong Wang
On Wed, Dec 16, 2020 at 10:29 PM Cong Wang wrote: > > On Wed, Dec 16, 2020 at 10:35 AM Andrii Nakryiko > wrote: > > Minimize duplication of the code, no one said copy/paste all the code. > > But memory bloat is a real problem and should be justification enough > > to at least consider other optio

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-16 Thread Cong Wang
On Wed, Dec 16, 2020 at 10:35 AM Andrii Nakryiko wrote: > > On Tue, Dec 15, 2020 at 4:15 PM Cong Wang wrote: > > > > On Tue, Dec 15, 2020 at 2:08 PM Andrii Nakryiko > > wrote: > > > > > > On Tue, Dec 15, 2020 at 12:06 PM Cong Wang > > > wrote: > > > > > > > > On Tue, Dec 15, 2020 at 11:27 AM A

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-16 Thread Cong Wang
On Tue, Dec 15, 2020 at 6:35 PM Alexei Starovoitov wrote: > > On Tue, Dec 15, 2020 at 6:10 PM Cong Wang wrote: > > > > Sure, people also implement CT on native hash map too and timeout > > with user-space timers. ;) > > exactly. what's wrong with that? > Perfectly fine way to do CT. Seriously? W

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-16 Thread Andrii Nakryiko
On Tue, Dec 15, 2020 at 4:15 PM Cong Wang wrote: > > On Tue, Dec 15, 2020 at 2:08 PM Andrii Nakryiko > wrote: > > > > On Tue, Dec 15, 2020 at 12:06 PM Cong Wang wrote: > > > > > > On Tue, Dec 15, 2020 at 11:27 AM Andrii Nakryiko > > > wrote: > > > > > > > > On Mon, Dec 14, 2020 at 12:17 PM Cong

RE: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-16 Thread David Laight
From: Alexei Starovoitov > Sent: 16 December 2020 02:36 ... > > The problem is never about granularity, it is about how efficient we can > > GC. User-space has to scan the whole table one by one, while the kernel > > can just do this behind the scene with a much lower overhead. > > > > Let's say we

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-15 Thread Alexei Starovoitov
On Tue, Dec 15, 2020 at 6:10 PM Cong Wang wrote: > > On Tue, Dec 15, 2020 at 5:14 PM Alexei Starovoitov > wrote: > > > > On Tue, Dec 15, 2020 at 04:22:21PM -0800, Cong Wang wrote: > > > On Tue, Dec 15, 2020 at 3:23 PM Daniel Borkmann > > > wrote: > > > > > > > > On 12/15/20 11:03 PM, Andrii Nak

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-15 Thread Cong Wang
On Tue, Dec 15, 2020 at 5:14 PM Alexei Starovoitov wrote: > > On Tue, Dec 15, 2020 at 04:22:21PM -0800, Cong Wang wrote: > > On Tue, Dec 15, 2020 at 3:23 PM Daniel Borkmann > > wrote: > > > > > > On 12/15/20 11:03 PM, Andrii Nakryiko wrote: > > > > On Tue, Dec 15, 2020 at 12:06 PM Cong Wang >

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-15 Thread Alexei Starovoitov
On Tue, Dec 15, 2020 at 04:22:21PM -0800, Cong Wang wrote: > On Tue, Dec 15, 2020 at 3:23 PM Daniel Borkmann wrote: > > > > On 12/15/20 11:03 PM, Andrii Nakryiko wrote: > > > On Tue, Dec 15, 2020 at 12:06 PM Cong Wang > > > wrote: > > >> > > >> On Tue, Dec 15, 2020 at 11:27 AM Andrii Nakryiko >

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-15 Thread Cong Wang
On Tue, Dec 15, 2020 at 3:23 PM Daniel Borkmann wrote: > > On 12/15/20 11:03 PM, Andrii Nakryiko wrote: > > On Tue, Dec 15, 2020 at 12:06 PM Cong Wang wrote: > >> > >> On Tue, Dec 15, 2020 at 11:27 AM Andrii Nakryiko > >> wrote: > >>> > >>> On Mon, Dec 14, 2020 at 12:17 PM Cong Wang > >>> wrot

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-15 Thread Cong Wang
On Tue, Dec 15, 2020 at 2:08 PM Andrii Nakryiko wrote: > > On Tue, Dec 15, 2020 at 12:06 PM Cong Wang wrote: > > > > On Tue, Dec 15, 2020 at 11:27 AM Andrii Nakryiko > > wrote: > > > > > > On Mon, Dec 14, 2020 at 12:17 PM Cong Wang > > > wrote: > > > > > > > > From: Cong Wang > > > > > > > >

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-15 Thread Daniel Borkmann
On 12/15/20 11:03 PM, Andrii Nakryiko wrote: On Tue, Dec 15, 2020 at 12:06 PM Cong Wang wrote: On Tue, Dec 15, 2020 at 11:27 AM Andrii Nakryiko wrote: On Mon, Dec 14, 2020 at 12:17 PM Cong Wang wrote: From: Cong Wang This borrows the idea from conntrack and will be used for conntrack i

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-15 Thread Andrii Nakryiko
On Tue, Dec 15, 2020 at 12:06 PM Cong Wang wrote: > > On Tue, Dec 15, 2020 at 11:27 AM Andrii Nakryiko > wrote: > > > > On Mon, Dec 14, 2020 at 12:17 PM Cong Wang wrote: > > > > > > From: Cong Wang > > > > > > This borrows the idea from conntrack and will be used for conntrack in > > > bpf too.

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-15 Thread Cong Wang
On Tue, Dec 15, 2020 at 11:27 AM Andrii Nakryiko wrote: > > On Mon, Dec 14, 2020 at 12:17 PM Cong Wang wrote: > > > > From: Cong Wang > > > > This borrows the idea from conntrack and will be used for conntrack in > > bpf too. Each element in a timeout map has a user-specified timeout > > in secs

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-15 Thread Andrii Nakryiko
On Mon, Dec 14, 2020 at 12:17 PM Cong Wang wrote: > > From: Cong Wang > > This borrows the idea from conntrack and will be used for conntrack in > bpf too. Each element in a timeout map has a user-specified timeout > in secs, after it expires it will be automatically removed from the map. > > The

[Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-14 Thread Cong Wang
From: Cong Wang This borrows the idea from conntrack and will be used for conntrack in bpf too. Each element in a timeout map has a user-specified timeout in secs, after it expires it will be automatically removed from the map. There are two cases here: 1. When the timeout map is idle, that is,