Re: [Patch 09/13] mv643xx_eth: Hold spinlocks only where needed

2006-01-19 Thread Olaf Hering
On Wed, Jan 18, Dale Farnsworth wrote: > On Wed, Jan 18, 2006 at 04:26:00PM +0100, Olaf Hering wrote: > > I havent checked if this patch is the culprit, but 2.6.16-rc1-git1 does > > lockup after modprobe -v mv643xx_eth , dhcpcd eth2. > > Have to find a serial console for the pegasos, all I get on

Re: [Patch 09/13] mv643xx_eth: Hold spinlocks only where needed

2006-01-18 Thread Dale Farnsworth
On Wed, Jan 18, 2006 at 04:26:00PM +0100, Olaf Hering wrote: > I havent checked if this patch is the culprit, but 2.6.16-rc1-git1 does > lockup after modprobe -v mv643xx_eth , dhcpcd eth2. > Have to find a serial console for the pegasos, all I get on console is > > BUG: spinlock recursion on CPU#0

Re: [Patch 09/13] mv643xx_eth: Hold spinlocks only where needed

2006-01-18 Thread Dale Farnsworth
On Wed, Jan 18, 2006 at 04:26:00PM +0100, Olaf Hering wrote: > On Mon, Jan 16, Dale Farnsworth wrote: > > > This driver has historically held a spin_lock during the entire open > > and stop functions and while receiving multiple packets. This is > > unecessarily long and holds locks during calls

Re: [Patch 09/13] mv643xx_eth: Hold spinlocks only where needed

2006-01-18 Thread Olaf Hering
On Mon, Jan 16, Dale Farnsworth wrote: > This driver has historically held a spin_lock during the entire open > and stop functions and while receiving multiple packets. This is > unecessarily long and holds locks during calls that may sleep. > This patch reduces the size of windows where locks a

[Patch 09/13] mv643xx_eth: Hold spinlocks only where needed

2006-01-16 Thread Dale Farnsworth
From: Dale Farnsworth <[EMAIL PROTECTED]> This driver has historically held a spin_lock during the entire open and stop functions and while receiving multiple packets. This is unecessarily long and holds locks during calls that may sleep. This patch reduces the size of windows where locks are hel