Re: [Patch] mqueue: fix netlink sock refcnt and skb refcnt

2017-07-11 Thread Cong Wang
On Mon, Jul 10, 2017 at 11:09 AM, Linus Torvalds wrote: > This thing is definitely not cc'd to the right people: > > On Sun, Jul 9, 2017 at 10:08 PM, Cong Wang wrote: >> >> Cc: Linus Torvalds >> Cc: Andrew Morton >> Cc: Manfred Spraul >> Signed-off-by: Cong Wang > > Unlike your previous patch

Re: [Patch] mqueue: fix netlink sock refcnt and skb refcnt

2017-07-10 Thread Linus Torvalds
This thing is definitely not cc'd to the right people: On Sun, Jul 9, 2017 at 10:08 PM, Cong Wang wrote: > > Cc: Linus Torvalds > Cc: Andrew Morton > Cc: Manfred Spraul > Signed-off-by: Cong Wang Unlike your previous patch, this seems to be more of a generic netlink interface issue, so you s

Re: [Patch] mqueue: fix netlink sock refcnt and skb refcnt

2017-07-10 Thread Cong Wang
On Sun, Jul 9, 2017 at 10:08 PM, Cong Wang wrote: > netlink_sendskb() is problematic, it releases sock refcnt > silently which could cause troubles we can call it multiple > times. info->notify_sock is a good example where we > setup once and use it to send netlink skb's for many times. > It shoul

[Patch] mqueue: fix netlink sock refcnt and skb refcnt

2017-07-09 Thread Cong Wang
netlink_sendskb() is problematic, it releases sock refcnt silently which could cause troubles we can call it multiple times. info->notify_sock is a good example where we setup once and use it to send netlink skb's for many times. It should not hold or release any refcnt, but needs to rely on netlin