Re: [Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread Xiaolan Zhang
I see. The build was fine under x86 and there are so many warnings that a -Werror probably won't work for me. thanks, Catherine David Miller <[EMAIL PROTECTED]> wrote on 08/02/2006 06:19:06 PM: > From: Xiaolan Zhang <[EMAIL PROTECTED]> > Date: Wed, 2 Aug 2006 18:18:07 -0400 > > > I did test i

Re: [Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread David Miller
From: Xiaolan Zhang <[EMAIL PROTECTED]> Date: Wed, 2 Aug 2006 18:18:07 -0400 > I did test it with CONFIG_SECURITY disabled, but did not catch the warning > -- I verified that the build completes with a valid vmlinux image. There > are many warnings (device drivers, and others) during the build

Re: [Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread Xiaolan Zhang
David, I did test it with CONFIG_SECURITY disabled, but did not catch the warning -- I verified that the build completes with a valid vmlinux image. There are many warnings (device drivers, and others) during the build and I didn't do a grep to find which one is specific to my patch. Next tim

Re: [Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread David Miller
From: Xiaolan Zhang <[EMAIL PROTECTED]> Date: Wed, 2 Aug 2006 17:14:31 -0400 > I will remember this in the future, I promise. Can you also remember to test your patches with CONFIG_SECURITY disabled, as you also promised in the past several times?!??!?! In file included from init/main.c:34: incl

Re: [Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread Xiaolan Zhang
David, I will remember this in the future, I promise. thank you, Catherine David Miller <[EMAIL PROTECTED]> wrote on 08/02/2006 05:11:03 PM: > > Catherine you really must begin to remember to add > proper "Signed-off-by: " lines to your patch submissions. > > I'll sign off on this bug fix, bu

Re: [Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread David Miller
Catherine you really must begin to remember to add proper "Signed-off-by: " lines to your patch submissions. I'll sign off on this bug fix, but in the future I will not do so for you any more as you've been told at least 3 or 4 times about this. Thank you. - To unsubscribe from this list: send t

Re: [Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread Michal Piotrowski
Hi Catherine, On 02/08/06, Catherine Zhang <[EMAIL PROTECTED]> wrote: Hi, all, Enclosed please find the updated patch incorporating comments from Stephen and Dave. Thanks! Again thanks for your help! Catherine -- Regards, Michal -- Michal K. K. Piotrowski LTG - Linux Testers Group (htt

Re: [Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-02 Thread Stephen Smalley
On Wed, 2006-08-02 at 02:47 -0400, Catherine Zhang wrote: > Hi, all, > > Enclosed please find the updated patch incorporating comments from > Stephen and Dave. Note that this patch is intended for 2.6.18 as a bug fix for the memory leak introduced by the original dgram peersec patches. > Again t

[Patch] kernel memory leak fix for af_unix datagram getpeersec patch

2006-08-01 Thread Catherine Zhang
Hi, all, Enclosed please find the updated patch incorporating comments from Stephen and Dave. Again thanks for your help! Catherine -- From: [EMAIL PROTECTED] This patch implements a cleaner fix for the memory leak problem of the original unix datagram getpeersec patch. Instead of creating