Re: [PATH bpf-next 2/2] selftests/bpf: Check that flow dissector can be re-attached

2019-10-10 Thread Stanislav Fomichev
On 10/10, Jakub Sitnicki wrote: > On Thu, Oct 10, 2019 at 06:31 PM CEST, Stanislav Fomichev wrote: > > On 10/10, Jakub Sitnicki wrote: > >> On Wed, Oct 09, 2019 at 06:33 PM CEST, Stanislav Fomichev wrote: > >> > On 10/09, Jakub Sitnicki wrote: > > [...] > > >> >> +/* Not used here. For CHECK macr

Re: [PATH bpf-next 2/2] selftests/bpf: Check that flow dissector can be re-attached

2019-10-10 Thread Jakub Sitnicki
On Thu, Oct 10, 2019 at 06:31 PM CEST, Stanislav Fomichev wrote: > On 10/10, Jakub Sitnicki wrote: >> On Wed, Oct 09, 2019 at 06:33 PM CEST, Stanislav Fomichev wrote: >> > On 10/09, Jakub Sitnicki wrote: [...] >> >> +/* Not used here. For CHECK macro sake only. */ >> >> +static int duration; >> >

Re: [PATH bpf-next 2/2] selftests/bpf: Check that flow dissector can be re-attached

2019-10-10 Thread Stanislav Fomichev
On 10/10, Jakub Sitnicki wrote: > On Wed, Oct 09, 2019 at 06:33 PM CEST, Stanislav Fomichev wrote: > > On 10/09, Jakub Sitnicki wrote: > >> Make sure a new flow dissector program can be attached to replace the old > >> one with a single syscall. Also check that attaching the same program twice > >>

Re: [PATH bpf-next 2/2] selftests/bpf: Check that flow dissector can be re-attached

2019-10-10 Thread Jakub Sitnicki
On Wed, Oct 09, 2019 at 06:33 PM CEST, Stanislav Fomichev wrote: > On 10/09, Jakub Sitnicki wrote: >> Make sure a new flow dissector program can be attached to replace the old >> one with a single syscall. Also check that attaching the same program twice >> is prohibited. > Overall the series looks

Re: [PATH bpf-next 2/2] selftests/bpf: Check that flow dissector can be re-attached

2019-10-09 Thread Stanislav Fomichev
On 10/09, Jakub Sitnicki wrote: > Make sure a new flow dissector program can be attached to replace the old > one with a single syscall. Also check that attaching the same program twice > is prohibited. Overall the series looks good, left a bunch of nits/questions below. > Signed-off-by: Jakub Sit

[PATH bpf-next 2/2] selftests/bpf: Check that flow dissector can be re-attached

2019-10-09 Thread Jakub Sitnicki
Make sure a new flow dissector program can be attached to replace the old one with a single syscall. Also check that attaching the same program twice is prohibited. Signed-off-by: Jakub Sitnicki --- .../bpf/prog_tests/flow_dissector_reattach.c | 93 +++ 1 file changed, 93 insert