Re: [PATCHv3 net 2/6] openvswitch: Fix skb leak in ovs_fragment()

2015-10-06 Thread Joe Stringer
On 6 October 2015 at 07:12, Sergei Shtylyov wrote: > Hello. > > On 10/6/2015 1:23 AM, Joe Stringer wrote: > >> If ovs_fragment() was unable to fragment the skb due to an L2 header >> that exceeds the supported length, skbs would be leaked. Fix the bug. >> >> Fixes: 7f8a436 "openvswitch: Add conntr

Re: [PATCHv3 net 2/6] openvswitch: Fix skb leak in ovs_fragment()

2015-10-06 Thread Sergei Shtylyov
Hello. On 10/6/2015 1:23 AM, Joe Stringer wrote: If ovs_fragment() was unable to fragment the skb due to an L2 header that exceeds the supported length, skbs would be leaked. Fix the bug. Fixes: 7f8a436 "openvswitch: Add conntrack action" 12-digit SHA1 needed here. And parens along with d

[PATCHv3 net 2/6] openvswitch: Fix skb leak in ovs_fragment()

2015-10-05 Thread Joe Stringer
If ovs_fragment() was unable to fragment the skb due to an L2 header that exceeds the supported length, skbs would be leaked. Fix the bug. Fixes: 7f8a436 "openvswitch: Add conntrack action" Signed-off-by: Joe Stringer Acked-by: Pravin B Shelar --- v3: Acked. v2: Drop if condition by returning in