Re: [PATCHv3 net-next 5/7] net: add confirm_neigh method to dst_ops

2017-02-03 Thread Steffen Klassert
On Fri, Feb 03, 2017 at 11:16:16AM +0200, Julian Anastasov wrote: > > Hello, > > On Fri, 3 Feb 2017, Steffen Klassert wrote: > > > > I thought about this (completely untested) one: > > > > static void xfrm_confirm_neigh(const struct dst_entry *dst, const void > > *daddr) > > > > { > >

Re: [PATCHv3 net-next 5/7] net: add confirm_neigh method to dst_ops

2017-02-03 Thread Julian Anastasov
Hello, On Fri, 3 Feb 2017, Steffen Klassert wrote: > On Thu, Feb 02, 2017 at 01:04:34AM +0200, Julian Anastasov wrote: > > > > It may sounds good. But only dst->path->ops->confirm_neigh > > points to real IPv4/IPv6 function. And also, I guess, the > > family can change while walking

Re: [PATCHv3 net-next 5/7] net: add confirm_neigh method to dst_ops

2017-02-02 Thread Steffen Klassert
On Thu, Feb 02, 2017 at 01:04:34AM +0200, Julian Anastasov wrote: > > Hello, > > On Wed, 1 Feb 2017, Steffen Klassert wrote: > > > > > I think here it is better to go through the whole chain > > of transformations with > > > > child->ops->confirm_neigh(path, daddr); > > It may sou

Re: [PATCHv3 net-next 5/7] net: add confirm_neigh method to dst_ops

2017-02-01 Thread Julian Anastasov
Hello, On Wed, 1 Feb 2017, Steffen Klassert wrote: > On Tue, Jan 31, 2017 at 11:57:05PM +0200, Julian Anastasov wrote: > > > > +static void xfrm_confirm_neigh(const struct dst_entry *dst, const void > > *daddr) > > +{ > > + const struct dst_entry *path = dst->path; > > + > > + if

Re: [PATCHv3 net-next 5/7] net: add confirm_neigh method to dst_ops

2017-01-31 Thread Steffen Klassert
On Tue, Jan 31, 2017 at 11:57:05PM +0200, Julian Anastasov wrote: > > static unsigned int ip6_blackhole_mtu(const struct dst_entry *dst) > diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c > index 177e208..c010ee0 100644 > --- a/net/xfrm/xfrm_policy.c > +++ b/net/xfrm/xfrm_policy.c >

[PATCHv3 net-next 5/7] net: add confirm_neigh method to dst_ops

2017-01-31 Thread Julian Anastasov
Add confirm_neigh method to dst_ops and use it from IPv4 and IPv6 to lookup and confirm the neighbour. Its usage via the new helper dst_confirm_neigh() should be restricted to MSG_PROBE users for performance reasons. Signed-off-by: Julian Anastasov Acked-by: Eric Dumazet --- include/net/arp.h