Re: [PATCHv3 net-next 1/2] net: move the hsize check to the else block in skb_segment

2021-01-16 Thread Jakub Kicinski
On Fri, 15 Jan 2021 17:39:02 -0800 Alexander Duyck wrote: > On Fri, Jan 15, 2021 at 1:36 AM Xin Long wrote: > > > > After commit 89319d3801d1 ("net: Add frag_list support to skb_segment"), > > it goes to process frag_list when !hsize in skb_segment(). However, when > > using skb frag_list, sg norm

Re: [PATCHv3 net-next 1/2] net: move the hsize check to the else block in skb_segment

2021-01-15 Thread Alexander Duyck
On Fri, Jan 15, 2021 at 1:36 AM Xin Long wrote: > > After commit 89319d3801d1 ("net: Add frag_list support to skb_segment"), > it goes to process frag_list when !hsize in skb_segment(). However, when > using skb frag_list, sg normally should not be set. In this case, hsize > will be set with len r

[PATCHv3 net-next 1/2] net: move the hsize check to the else block in skb_segment

2021-01-15 Thread Xin Long
After commit 89319d3801d1 ("net: Add frag_list support to skb_segment"), it goes to process frag_list when !hsize in skb_segment(). However, when using skb frag_list, sg normally should not be set. In this case, hsize will be set with len right before !hsize check, then it won't go to frag_list pro