Re: [PATCHv3 net] ipv6: no need to return rt->dst.error if it is prohibit entry

2017-07-27 Thread Hangbin Liu
On Wed, Jul 26, 2017 at 11:09:39AM -0600, David Ahern wrote: > On 7/26/17 3:20 AM, Hangbin Liu wrote: > > After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib > > result when requested"). When we get a prohibit ertry, we will return > > -EACCES directly. > > > > Before: > > Do

Re: [PATCHv3 net] ipv6: no need to return rt->dst.error if it is prohibit entry

2017-07-26 Thread David Ahern
On 7/26/17 11:09 AM, David Ahern wrote: > I don't understand why you are focused on the built-in null and prohibit > route entries. I see. You are using fib rules for the prohibit entry; I am using an explicit route entry. If I run 'ip ro get fibmatch' for the latter I want to see that route ent

Re: [PATCHv3 net] ipv6: no need to return rt->dst.error if it is prohibit entry

2017-07-26 Thread David Ahern
On 7/26/17 3:20 AM, Hangbin Liu wrote: > After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib > result when requested"). When we get a prohibit ertry, we will return > -EACCES directly. > > Before: Do you mean "Before commit 18c3a61c4264?" > + ip netns exec client ip -6 route

[PATCHv3 net] ipv6: no need to return rt->dst.error if it is prohibit entry

2017-07-26 Thread Hangbin Liu
After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib result when requested"). When we get a prohibit ertry, we will return -EACCES directly. Before: + ip netns exec client ip -6 route get 2003::1 prohibit 2003::1 dev lo table unspec proto kernel src 2001::1 metric 4294967295 err