RE: [PATCHv3 5/7] tap: Extending tap device create/destroy APIs

2017-02-02 Thread Grandhi, Sainath
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, January 31, 2017 9:51 AM > To: Grandhi, Sainath > Cc: netdev@vger.kernel.org; mah...@bandewar.net; linux- > ker...@vger.kernel.org > Subject: Re: [PATCHv3 5/7] tap: Extend

Re: [PATCHv3 5/7] tap: Extending tap device create/destroy APIs

2017-01-31 Thread David Miller
From: Sainath Grandhi Date: Mon, 30 Jan 2017 11:12:00 -0800 > + list_for_each_entry_safe(tap_major, tmp, &major_list, next) { > + if (tap_major->major == major) { > + return tap_major; > + } > + } Single line basic blocks, such as this 'if' sta

[PATCHv3 5/7] tap: Extending tap device create/destroy APIs

2017-01-30 Thread Sainath Grandhi
Extending tap APIs get/free_minor and create/destroy_cdev to handle more than one type of virtual interface. Signed-off-by: Sainath Grandhi --- drivers/net/macvtap_main.c | 6 +-- drivers/net/tap.c | 98 +++--- include/linux/if_tap.h | 4 +-

[PATCHv3 5/7] TAP: Extending tap device create/destroy APIs

2017-01-25 Thread Sainath Grandhi
Extending tap APIs get/free_minor and create/destroy_cdev to handle more than one type of virtual interface. Signed-off-by: Sainath Grandhi --- drivers/net/macvtap_main.c | 6 +-- drivers/net/tap.c | 98 +++--- include/linux/if_tap.h | 4 +-