Re: [PATCHv3 1/3] usbnet: specify naming of usbnet_set/get_link_ksettings

2021-02-18 Thread Grant Grundler
On Thu, Feb 18, 2021 at 7:50 PM Andrew Lunn wrote: > > On Thu, Feb 18, 2021 at 07:31:41PM +, Grant Grundler wrote: > > Oliver, Jakub, > > Can I post v4 and deal with the issues below? > > You should probably wait for two weeks. We are far enough into the > merge window that i doubt it will get

Re: [PATCHv3 1/3] usbnet: specify naming of usbnet_set/get_link_ksettings

2021-02-18 Thread Andrew Lunn
On Thu, Feb 18, 2021 at 07:31:41PM +, Grant Grundler wrote: > Oliver, Jakub, > Can I post v4 and deal with the issues below? You should probably wait for two weeks. We are far enough into the merge window that i doubt it will get picked up. So please wait, rebase, and then post. > Nit: The v2

Re: [PATCHv3 1/3] usbnet: specify naming of usbnet_set/get_link_ksettings

2021-02-18 Thread Grant Grundler
Oliver, Jakub, Can I post v4 and deal with the issues below? I can compile and test against ToT for now and I'll like to get this mess behind me. I still think the first patch in this series should revert my previous change (de658a195ee23ca6aaffe197d1d2ea040beea0a2). On Thu, Feb 18, 2021 at 10:2

Re: [PATCHv3 1/3] usbnet: specify naming of usbnet_set/get_link_ksettings

2021-02-18 Thread Jakub Kicinski
On Thu, 18 Feb 2021 11:20:36 +0100 Oliver Neukum wrote: > The old generic functions assume that the devices includes > an MDIO interface. This is true only for genuine ethernet. > Devices with a higher level of abstraction or based on different > technologies do not have it. So in preparation for >

[PATCHv3 1/3] usbnet: specify naming of usbnet_set/get_link_ksettings

2021-02-18 Thread Oliver Neukum
The old generic functions assume that the devices includes an MDIO interface. This is true only for genuine ethernet. Devices with a higher level of abstraction or based on different technologies do not have it. So in preparation for supporting that, we rename the old functions to something specifi