Re: [PATCHv3] net/ipv6: add sysctl option accept_ra_min_hop_limit

2015-07-29 Thread Hangbin Liu
2015-07-30 8:45 GMT+08:00 YOSHIFUJI Hideaki : >>> How about ignoring hop limit without message is configured value is >>> larger than 255, BTW? >> >> Although set accept_ra_min_hop_limit great than 255 is meaningless, there >> is also no need to check it since icmp6_hop_limit will not larger than

Re: [PATCHv3] net/ipv6: add sysctl option accept_ra_min_hop_limit

2015-07-29 Thread YOSHIFUJI Hideaki
Hi, Hangbin Liu wrote: >>> diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c >>> index 0a05b35..acda056 100644 >>> --- a/net/ipv6/ndisc.c >>> +++ b/net/ipv6/ndisc.c >>> @@ -1226,13 +1226,11 @@ static void ndisc_router_discovery(struct sk_buff >>> *skb) >>> if (rt) >>> rt6_set_e

Re: [PATCHv3] net/ipv6: add sysctl option accept_ra_min_hop_limit

2015-07-29 Thread Hangbin Liu
Hi Yoshifuji-san, Please see comments in the mail. 2015-07-29 18:39 GMT+08:00 YOSHIFUJI Hideaki : > Hi, > > Thank you for you updated patch. > > Hangbin Liu wrote: >> Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") >> disabled accept hop limit from RA if it is higher than th

Re: [PATCHv3] net/ipv6: add sysctl option accept_ra_min_hop_limit

2015-07-29 Thread YOSHIFUJI Hideaki
Hi, Thank you for you updated patch. Hangbin Liu wrote: > Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") > disabled accept hop limit from RA if it is higher than the current hop > limit for security stuff. But this behavior kind of break the RFC definition. > > RFC 4861, 6

[PATCHv3] net/ipv6: add sysctl option accept_ra_min_hop_limit

2015-07-29 Thread Hangbin Liu
Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") disabled accept hop limit from RA if it is higher than the current hop limit for security stuff. But this behavior kind of break the RFC definition. RFC 4861, 6.3.4. Processing Received Router Advertisements A Router Adverti