Re: [PATCHv2 next 3/3] blackhole_dev: add a selftest

2019-07-01 Thread महेश बंडेवार
On Sat, Jun 29, 2019 at 12:28 PM David Miller wrote: > > From: Mahesh Bandewar > Date: Thu, 27 Jun 2019 12:43:09 -0700 > > > +config TEST_BLACKHOLE_DEV > > + tristate "Test BPF filter functionality" > > I think the tristate string needs to be changed :-) side effects of copy-paste :( sending

Re: [PATCHv2 next 3/3] blackhole_dev: add a selftest

2019-06-29 Thread David Miller
From: Mahesh Bandewar Date: Thu, 27 Jun 2019 12:43:09 -0700 > +config TEST_BLACKHOLE_DEV > + tristate "Test BPF filter functionality" I think the tristate string needs to be changed :-)

[PATCHv2 next 3/3] blackhole_dev: add a selftest

2019-06-27 Thread Mahesh Bandewar
Since this is not really a device with all capabilities, this test ensures that it has *enough* to make it through the data path without causing unwanted side-effects (read crash!). Signed-off-by: Mahesh Bandewar --- v1 -> v2 fixed the conflict resolution in selftests Makefile lib/Kconfig.deb