Re: [PATCHv2 net-next 02/17] udp6: move the mss check after udp gso tunnel processing

2020-10-09 Thread Willem de Bruijn
On Thu, Oct 8, 2020 at 9:49 PM Xin Long wrote: > > On Thu, Oct 8, 2020 at 8:45 PM Willem de Bruijn > wrote: > > > > On Thu, Oct 8, 2020 at 5:48 AM Xin Long wrote: > > > > > > For some protocol's gso, like SCTP, it's using GSO_BY_FRAGS for > > > gso_size. When using UDP to encapsulate its packet,

Re: [PATCHv2 net-next 02/17] udp6: move the mss check after udp gso tunnel processing

2020-10-08 Thread Xin Long
On Thu, Oct 8, 2020 at 8:45 PM Willem de Bruijn wrote: > > On Thu, Oct 8, 2020 at 5:48 AM Xin Long wrote: > > > > For some protocol's gso, like SCTP, it's using GSO_BY_FRAGS for > > gso_size. When using UDP to encapsulate its packet, it will > > return error in udp6_ufo_fragment() as skb->len < g

Re: [PATCHv2 net-next 02/17] udp6: move the mss check after udp gso tunnel processing

2020-10-08 Thread Willem de Bruijn
On Thu, Oct 8, 2020 at 5:48 AM Xin Long wrote: > > For some protocol's gso, like SCTP, it's using GSO_BY_FRAGS for > gso_size. When using UDP to encapsulate its packet, it will > return error in udp6_ufo_fragment() as skb->len < gso_size, > and it will never go to the gso tunnel processing. > > So

[PATCHv2 net-next 02/17] udp6: move the mss check after udp gso tunnel processing

2020-10-08 Thread Xin Long
For some protocol's gso, like SCTP, it's using GSO_BY_FRAGS for gso_size. When using UDP to encapsulate its packet, it will return error in udp6_ufo_fragment() as skb->len < gso_size, and it will never go to the gso tunnel processing. So we should move this check after udp gso tunnel processing, t