Re: [PATCHv2 net-next] ipv6: allow routes to be configured with expire values

2015-12-16 Thread Xin Long
On Tue, Dec 15, 2015 at 3:36 AM, David Miller wrote: > From: Hannes Frederic Sowa > Date: Mon, 14 Dec 2015 18:16:59 +0100 > >> We can easily switch to new attributes. Should we introduce a new >> interface for this? > > Yes. okay, I will repost the patch with a new netlink attribute -- To unsubsc

Re: [PATCHv2 net-next] ipv6: allow routes to be configured with expire values

2015-12-14 Thread David Miller
From: Hannes Frederic Sowa Date: Mon, 14 Dec 2015 18:16:59 +0100 > We can easily switch to new attributes. Should we introduce a new > interface for this? Yes. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordom

Re: [PATCHv2 net-next] ipv6: allow routes to be configured with expire values

2015-12-14 Thread Hannes Frederic Sowa
Hi, On 14.12.2015 12:48, Xin Long wrote: >> >> This is the wrong way to do this. >> >> Currently we only ever dump rta_cacheinfo values to the user. >> >> If we use it to set things, we have to completely consider every >> member of that structure as potentially having meaning either >> intended b

Re: [PATCHv2 net-next] ipv6: allow routes to be configured with expire values

2015-12-14 Thread Xin Long
> > This is the wrong way to do this. > > Currently we only ever dump rta_cacheinfo values to the user. > > If we use it to set things, we have to completely consider every > member of that structure as potentially having meaning either > intended by the user or choosen by us in the future. > > The

Re: [PATCHv2 net-next] ipv6: allow routes to be configured with expire values

2015-12-11 Thread David Miller
From: Xin Long Date: Thu, 10 Dec 2015 00:27:53 +0800 > Add the support for adding expire value to routes, requested by > Tom Gundersen for systemd-networkd, and NetworkManager > wants it too. > > add it by using the field rta_expires of rta_cacheinfo > > Signed-off-by: Xin Long > Signed-off-

[PATCHv2 net-next] ipv6: allow routes to be configured with expire values

2015-12-09 Thread Xin Long
Add the support for adding expire value to routes, requested by Tom Gundersen for systemd-networkd, and NetworkManager wants it too. add it by using the field rta_expires of rta_cacheinfo Signed-off-by: Xin Long Signed-off-by: Hannes Frederic Sowa --- net/ipv6/route.c | 11 +++ 1 fil