Re: [PATCHv2 net] sctp: do not check port in sctp_inet6_cmp_addr

2018-04-12 Thread David Miller
From: Xin Long Date: Thu, 12 Apr 2018 14:24:31 +0800 > pf->cmp_addr() is called before binding a v6 address to the sock. It > should not check ports, like in sctp_inet_cmp_addr. > > But sctp_inet6_cmp_addr checks the addr by invoking af(6)->cmp_addr, > sctp_v6_cmp_addr where it also compares the

Re: [PATCHv2 net] sctp: do not check port in sctp_inet6_cmp_addr

2018-04-12 Thread Neil Horman
On Thu, Apr 12, 2018 at 02:24:31PM +0800, Xin Long wrote: > pf->cmp_addr() is called before binding a v6 address to the sock. It > should not check ports, like in sctp_inet_cmp_addr. > > But sctp_inet6_cmp_addr checks the addr by invoking af(6)->cmp_addr, > sctp_v6_cmp_addr where it also compares

[PATCHv2 net] sctp: do not check port in sctp_inet6_cmp_addr

2018-04-11 Thread Xin Long
pf->cmp_addr() is called before binding a v6 address to the sock. It should not check ports, like in sctp_inet_cmp_addr. But sctp_inet6_cmp_addr checks the addr by invoking af(6)->cmp_addr, sctp_v6_cmp_addr where it also compares the ports. This would cause that setsockopt(SCTP_SOCKOPT_BINDX_ADD)