Re: [PATCHv2 net] ipv6/addrconf: allow adding multicast addr if IFA_F_MCAUTOJOIN is set

2019-08-23 Thread David Ahern
On 8/22/19 4:20 AM, Hangbin Liu wrote: > On Mon, Aug 19, 2019 at 10:33:58PM -0400, David Ahern wrote: >> On 8/19/19 10:19 PM, Hangbin Liu wrote: >>> But in ipv6_add_addr() it will check the address type and reject multicast >>> address directly. So this feature is never worked for IPv6. >> >> If tr

Re: [PATCHv2 net] ipv6/addrconf: allow adding multicast addr if IFA_F_MCAUTOJOIN is set

2019-08-22 Thread Hangbin Liu
On Mon, Aug 19, 2019 at 10:33:58PM -0400, David Ahern wrote: > On 8/19/19 10:19 PM, Hangbin Liu wrote: > > But in ipv6_add_addr() it will check the address type and reject multicast > > address directly. So this feature is never worked for IPv6. > > If true, that is really disappointing. > > We n

Re: [PATCHv2 net] ipv6/addrconf: allow adding multicast addr if IFA_F_MCAUTOJOIN is set

2019-08-21 Thread David Miller
From: Hangbin Liu Date: Tue, 20 Aug 2019 10:19:47 +0800 > In commit 93a714d6b53d ("multicast: Extend ip address command to enable > multicast group join/leave on") we added a new flag IFA_F_MCAUTOJOIN > to make user able to add multicast address on ethernet interface. > > This works for IPv4, bu

Re: [PATCHv2 net] ipv6/addrconf: allow adding multicast addr if IFA_F_MCAUTOJOIN is set

2019-08-19 Thread David Ahern
On 8/19/19 10:19 PM, Hangbin Liu wrote: > But in ipv6_add_addr() it will check the address type and reject multicast > address directly. So this feature is never worked for IPv6. If true, that is really disappointing. We need to get a functional test script started for various address cases.

[PATCHv2 net] ipv6/addrconf: allow adding multicast addr if IFA_F_MCAUTOJOIN is set

2019-08-19 Thread Hangbin Liu
In commit 93a714d6b53d ("multicast: Extend ip address command to enable multicast group join/leave on") we added a new flag IFA_F_MCAUTOJOIN to make user able to add multicast address on ethernet interface. This works for IPv4, but not for IPv6. See the inet6_addr_add code. static int inet6_addr_