Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-19 Thread Joe Perches
On Sun, 2015-07-19 at 11:38 -0700, David Miller wrote: > From: Sowmini Varadhan > Date: Sun, 19 Jul 2015 14:01:34 +0200 > > > On 07/18/2015 08:06 PM, Joe Perches wrote: > > > >> It seems that this code has had unaligned accesses > >> on this field even before compare_ether_addr was > >> converte

Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-19 Thread David Miller
From: Sowmini Varadhan Date: Sun, 19 Jul 2015 14:01:34 +0200 > On 07/18/2015 08:06 PM, Joe Perches wrote: > >> It seems that this code has had unaligned accesses >> on this field even before compare_ether_addr was >> converted to ether_addr_equal. >> >> Is sparc64 the only one that emits / ratel

Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-19 Thread Sowmini Varadhan
On 07/18/2015 08:06 PM, Joe Perches wrote: It seems that this code has had unaligned accesses on this field even before compare_ether_addr was converted to ether_addr_equal. Is sparc64 the only one that emits / ratelimits that unaligned access message? I looked a little, but I didn't find a fi

Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-18 Thread David Miller
From: Joe Perches Date: Sat, 18 Jul 2015 11:06:26 -0700 > As it's not fatal, naybe the sparc64 message should be > KERN_DEBUG/pr_debug. It's not fatal insofar as it doesn't crash the system. But performance wise is _IS_ fatal, and I want the kernel to bark at the user so that they report the is

Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-18 Thread Joe Perches
On Fri, 2015-07-17 at 18:18 -0700, David Miller wrote: > From: Joe Perches Date: Fri, 17 Jul 2015 16:07:02 -0700 > > On Fri, 2015-07-17 at 22:00 +0200, Sowmini Varadhan wrote: > >> __vxlan_find_mac invokes ether_addr_equal on the eth_addr field, > >> which triggers unaligned access messages, so re

Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-17 Thread Sowmini Varadhan
On (07/17/15 16:07), Joe Perches wrote: > On Fri, 2015-07-17 at 22:00 +0200, Sowmini Varadhan wrote: > > __vxlan_find_mac invokes ether_addr_equal on the eth_addr field, > > which triggers unaligned access messages, so rearrange vxlan_fdb > > to avoid this in the most non-intrusive way. > > What a

Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-17 Thread David Miller
From: Joe Perches Date: Fri, 17 Jul 2015 16:07:02 -0700 > On Fri, 2015-07-17 at 22:00 +0200, Sowmini Varadhan wrote: >> __vxlan_find_mac invokes ether_addr_equal on the eth_addr field, >> which triggers unaligned access messages, so rearrange vxlan_fdb >> to avoid this in the most non-intrusive w

Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-17 Thread Joe Perches
On Fri, 2015-07-17 at 22:00 +0200, Sowmini Varadhan wrote: > __vxlan_find_mac invokes ether_addr_equal on the eth_addr field, > which triggers unaligned access messages, so rearrange vxlan_fdb > to avoid this in the most non-intrusive way. What arch does this? -- To unsubscribe from this list: s

[PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-17 Thread Sowmini Varadhan
__vxlan_find_mac invokes ether_addr_equal on the eth_addr field, which triggers unaligned access messages, so rearrange vxlan_fdb to avoid this in the most non-intrusive way. Signed-off-by: Sowmini Varadhan --- v2: Alexander Duyck comments: make eth_addr[] 64b aligned. drivers/net/vxlan.c |