Re: [PATCHv2 7/7] openvswitch: Change CT_ATTR_FLAGS to CT_ATTR_COMMIT

2015-10-01 Thread Pravin Shelar
On Thu, Oct 1, 2015 at 1:53 PM, Joe Stringer wrote: > Previously, the CT_ATTR_FLAGS attribute, when nested under the > OVS_ACTION_ATTR_CT, encoded a 32-bit bitmask of flags that modify the > semantics of the ct action. It's more extensible to just represent each > flag as a nested attribute, and t

[PATCHv2 7/7] openvswitch: Change CT_ATTR_FLAGS to CT_ATTR_COMMIT

2015-10-01 Thread Joe Stringer
Previously, the CT_ATTR_FLAGS attribute, when nested under the OVS_ACTION_ATTR_CT, encoded a 32-bit bitmask of flags that modify the semantics of the ct action. It's more extensible to just represent each flag as a nested attribute, and this requires no additional error checking to reject flags tha