Re: [PATCHv2 1/3] NET_SCHED: PSPacer qdisc module

2007-11-28 Thread Patrick McHardy
Ryousei Takano wrote: Hi Patrick, +struct tc_psp_qopt +{ + __u32 defcls; + __u32 rate; +}; What unit is rate measured in? 'rate' is the transmission rate in bytes per sec. So wouldn't it make sense to use u64 then for 10GBit networks? I decided to use u32 after tc_ratespe

Re: [PATCHv2 1/3] NET_SCHED: PSPacer qdisc module

2007-11-27 Thread Ryousei Takano
Hi Patrick, > >>> +struct tc_psp_qopt > >>> +{ > >>> + __u32 defcls; > >>> + __u32 rate; > >>> +}; > >> > >> What unit is rate measured in? > >> > > 'rate' is the transmission rate in bytes per sec. > > > So wouldn't it make sense to use u64 then for 10GBit networks? > I decided to use u32

Re: [PATCHv2 1/3] NET_SCHED: PSPacer qdisc module

2007-11-27 Thread Ryousei Takano
> One more thing: your qdisc can only be used as root qdisc since it > produces packets itself and thereby violates the rule that a qdisc > can only hand out packets that were previously enqueued to it. > Using it as a leaf qdisc can make the upper qdiscs qlen counter > go negative, causing infinit

Re: [PATCHv2 1/3] NET_SCHED: PSPacer qdisc module

2007-11-27 Thread Patrick McHardy
TAKANO Ryousei wrote: Hi Patrick, +struct tc_psp_qopt +{ + __u32 defcls; + __u32 rate; +}; What unit is rate measured in? 'rate' is the transmission rate in bytes per sec. So wouldn't it make sense to use u64 then for 10GBit networks? + skb_put(skb, size); This i

Re: [PATCHv2 1/3] NET_SCHED: PSPacer qdisc module

2007-11-27 Thread TAKANO Ryousei
Hi Patrick, I appreciate your comments. I will update and resend patches. > > +typedef long long gapclock_t; > > It seems you only add to this, does it need to be signed? > How about using a fixed size type (u64) and getting rid > of the typedef? > OK. I will use u64 instead of gapclock_t, and

Re: [PATCHv2 1/3] NET_SCHED: PSPacer qdisc module

2007-11-26 Thread Patrick McHardy
Ryousei Takano wrote: This patch includes the PSPacer (Precise Software Pacer) qdisc module, which achieves precise transmission bandwidth control. You can find more information at the project web page (http://www.gridmpi.org/gridtcp.jsp). Thanks for the update, but you didn't answer any of my

[PATCHv2 1/3] NET_SCHED: PSPacer qdisc module

2007-11-26 Thread Ryousei Takano
This patch includes the PSPacer (Precise Software Pacer) qdisc module, which achieves precise transmission bandwidth control. You can find more information at the project web page (http://www.gridmpi.org/gridtcp.jsp). Signed-off-by: Ryousei Takano <[EMAIL PROTECTED]> --- include/linux/pkt_sched.h