Re: [PATCHv2] net: suppress warnings on dev_alloc_skb

2016-05-20 Thread David Miller
From: Neil Horman Date: Thu, 19 May 2016 11:30:54 -0400 > Noticed an allocation failure in a network driver the other day on a 32 bit > system: ... > Thought that perhaps the big splat in the logs wasn't really necessecary, as > all call sites for dev_alloc_skb: > > a) check the return code for

Re: [PATCHv2] net: suppress warnings on dev_alloc_skb

2016-05-19 Thread Neil Horman
On Thu, May 19, 2016 at 10:39:50AM -0700, Eric Dumazet wrote: > On Thu, 2016-05-19 at 13:34 -0400, Neil Horman wrote: > > On Thu, May 19, 2016 at 08:48:56AM -0700, Eric Dumazet wrote: > > > On Thu, 2016-05-19 at 11:30 -0400, Neil Horman wrote: > > > > Noticed an allocation failure in a network driv

Re: [PATCHv2] net: suppress warnings on dev_alloc_skb

2016-05-19 Thread Eric Dumazet
On Thu, 2016-05-19 at 13:34 -0400, Neil Horman wrote: > On Thu, May 19, 2016 at 08:48:56AM -0700, Eric Dumazet wrote: > > On Thu, 2016-05-19 at 11:30 -0400, Neil Horman wrote: > > > Noticed an allocation failure in a network driver the other day on a 32 > > > bit > > > system: > > > > Presumably

Re: [PATCHv2] net: suppress warnings on dev_alloc_skb

2016-05-19 Thread Neil Horman
On Thu, May 19, 2016 at 08:48:56AM -0700, Eric Dumazet wrote: > On Thu, 2016-05-19 at 11:30 -0400, Neil Horman wrote: > > Noticed an allocation failure in a network driver the other day on a 32 bit > > system: > > Presumably driver could fall back to HIGH memory allocation for the page > frag. >

Re: [PATCHv2] net: suppress warnings on dev_alloc_skb

2016-05-19 Thread Eric Dumazet
On Thu, 2016-05-19 at 11:30 -0400, Neil Horman wrote: > Noticed an allocation failure in a network driver the other day on a 32 bit > system: Presumably driver could fall back to HIGH memory allocation for the page frag.

Re: [PATCHv2] net: suppress warnings on dev_alloc_skb

2016-05-19 Thread Eric Dumazet
On Thu, 2016-05-19 at 11:30 -0400, Neil Horman wrote: > Noticed an allocation failure in a network driver the other day on a 32 bit > system: > Signed-off-by: Neil Horman > CC: "David S. Miller" > CC: Eric Dumazet > CC: Alexander Duyck Acked-by: Eric Dumazet Thanks Neil

[PATCHv2] net: suppress warnings on dev_alloc_skb

2016-05-19 Thread Neil Horman
Noticed an allocation failure in a network driver the other day on a 32 bit system: DMA-API: debugging out of memory - disabling bnx2fc: adapter_lookup: hba NULL lldpad: page allocation failure. order:0, mode:0x4120 Pid: 4556, comm: lldpad Not tainted 2.6.32-639.el6.i686.debug #1 Call Trace: [] ?