Re: [PATCHSET] making unix_bind() undo mknod on failure

2021-02-23 Thread Jakub Kicinski
On Mon, 22 Feb 2021 19:06:00 + Al Viro wrote: > On Sat, Feb 20, 2021 at 09:08:56PM +, Al Viro wrote: > > > *shrug* > > > > If anything, __unix_complete_bind() might make a better name for that, > > with dropping ->bindlock also pulled in, but TBH I don't have sufficiently > > strong prefe

Re: [PATCHSET] making unix_bind() undo mknod on failure

2021-02-22 Thread Al Viro
On Mon, Feb 22, 2021 at 07:12:29PM +, Al Viro wrote: > On Mon, Feb 22, 2021 at 07:06:00PM +, Al Viro wrote: > > On Sat, Feb 20, 2021 at 09:08:56PM +, Al Viro wrote: > > > > > *shrug* > > > > > > If anything, __unix_complete_bind() might make a better name for that, > > > with dropping

Re: [PATCHSET] making unix_bind() undo mknod on failure

2021-02-22 Thread Al Viro
On Mon, Feb 22, 2021 at 07:06:00PM +, Al Viro wrote: > On Sat, Feb 20, 2021 at 09:08:56PM +, Al Viro wrote: > > > *shrug* > > > > If anything, __unix_complete_bind() might make a better name for that, > > with dropping ->bindlock also pulled in, but TBH I don't have sufficiently > > stron

[PATCHSET] making unix_bind() undo mknod on failure

2021-02-22 Thread Al Viro
On Sat, Feb 20, 2021 at 09:08:56PM +, Al Viro wrote: > *shrug* > > If anything, __unix_complete_bind() might make a better name for that, > with dropping ->bindlock also pulled in, but TBH I don't have sufficiently > strong preferences - might as well leave dropping the lock to caller. > > I