Re: [PATCH xfrm v1] xfrm: fix error flow in case of add state fails

2018-01-19 Thread Steffen Klassert
On Thu, Jan 18, 2018 at 03:41:51PM +0200, Aviad Yehezkel wrote: > If add state fails in case of device offload, netdev refcount > will be negative since gc task is attempting to dev_free this state. > This is fixed by putting NULL in state dev field. > > Signed-off-by: Aviad Yehezkel > Signed-off

Re: [PATCH xfrm v1] xfrm: fix error flow in case of add state fails

2018-01-18 Thread Shannon Nelson
On 1/18/2018 5:41 AM, Aviad Yehezkel wrote: If add state fails in case of device offload, netdev refcount will be negative since gc task is attempting to dev_free this state. This is fixed by putting NULL in state dev field. Signed-off-by: Aviad Yehezkel Signed-off-by: Boris Pismeny Thanks -

[PATCH xfrm v1] xfrm: fix error flow in case of add state fails

2018-01-18 Thread Aviad Yehezkel
If add state fails in case of device offload, netdev refcount will be negative since gc task is attempting to dev_free this state. This is fixed by putting NULL in state dev field. Signed-off-by: Aviad Yehezkel Signed-off-by: Boris Pismeny --- net/xfrm/xfrm_device.c | 1 + 1 file changed, 1 ins