Re: [PATCH wireless-dev] d80211: switch status codes, reason codes, and EIDs to enums

2006-08-15 Thread Johannes Berg
Michael Wu wrote: I don't really like the comments in the EID section. I would rather have the comments resemble the ones in ieee80211_statuscode which identifies 802.11b/h/g/i instead of just pointing out the ones that are 802.11h. If you want to do that, that would be great, though I can prob

Re: [PATCH wireless-dev] d80211: switch status codes, reason codes, and EIDs to enums

2006-08-14 Thread Michael Wu
On Monday 14 August 2006 00:54, Johannes Berg wrote: > > + WLAN_EID_IBSS_DFS = 41, > > /* EIDs defined as part fo 11h - ends */ > > Care to fix the two occurrences of this typo in a respun patch? (should > be 'of' instead of 'fo') > If you can't easily recreate that patch I'll send one after thi

Re: [PATCH wireless-dev] d80211: switch status codes, reason codes, and EIDs to enums

2006-08-14 Thread Johannes Berg
Michael Wu wrote: + WLAN_EID_QUIET = 40, I was about to send a patch fixing this as well :) + WLAN_EID_IBSS_DFS = 41, /* EIDs defined as part fo 11h - ends */ Care to fix the two occurrences of this typo in a respun patch? (should be 'of' instead of 'fo') If you can't easily r

[PATCH wireless-dev] d80211: switch status codes, reason codes, and EIDs to enums

2006-08-13 Thread Michael Wu
d80211: switch status codes, reason codes, and EIDs to enums This patch converts the status code, reason code, and EID defines in d80211_mgmt.h to enums. It also adds some status and reason codes, fixes some typos (DENOED, QUITE), and uses the ieee80211.h version of the name where reasonable.