Re: [PATCH vhost v6 02/10] virtio_ring: packed: remove double check of the unmap ops

2024-03-28 Thread Jason Wang
On Thu, Mar 28, 2024 at 4:16 PM Xuan Zhuo wrote: > > On Thu, 28 Mar 2024 16:07:14 +0800, Jason Wang wrote: > > On Thu, Mar 28, 2024 at 3:32 PM Xuan Zhuo > > wrote: > > > > > > On Thu, 28 Mar 2024 14:56:47 +0800, Jason Wang > > > wrote: > > > > On Wed, Mar 27, 2024 at 7:14 PM Xuan Zhuo > > >

Re: [PATCH vhost v6 02/10] virtio_ring: packed: remove double check of the unmap ops

2024-03-28 Thread Xuan Zhuo
On Thu, 28 Mar 2024 16:07:14 +0800, Jason Wang wrote: > On Thu, Mar 28, 2024 at 3:32 PM Xuan Zhuo wrote: > > > > On Thu, 28 Mar 2024 14:56:47 +0800, Jason Wang wrote: > > > On Wed, Mar 27, 2024 at 7:14 PM Xuan Zhuo > > > wrote: > > > > > > > > In the functions vring_unmap_extra_packed and vrin

Re: [PATCH vhost v6 02/10] virtio_ring: packed: remove double check of the unmap ops

2024-03-28 Thread Jason Wang
On Thu, Mar 28, 2024 at 3:32 PM Xuan Zhuo wrote: > > On Thu, 28 Mar 2024 14:56:47 +0800, Jason Wang wrote: > > On Wed, Mar 27, 2024 at 7:14 PM Xuan Zhuo > > wrote: > > > > > > In the functions vring_unmap_extra_packed and vring_unmap_desc_packed, > > > multiple checks are made whether unmap is

Re: [PATCH vhost v6 02/10] virtio_ring: packed: remove double check of the unmap ops

2024-03-28 Thread Xuan Zhuo
On Thu, 28 Mar 2024 14:56:47 +0800, Jason Wang wrote: > On Wed, Mar 27, 2024 at 7:14 PM Xuan Zhuo wrote: > > > > In the functions vring_unmap_extra_packed and vring_unmap_desc_packed, > > multiple checks are made whether unmap is performed and whether it is > > INDIRECT. > > > > These two functio

Re: [PATCH vhost v6 02/10] virtio_ring: packed: remove double check of the unmap ops

2024-03-27 Thread Jason Wang
On Wed, Mar 27, 2024 at 7:14 PM Xuan Zhuo wrote: > > In the functions vring_unmap_extra_packed and vring_unmap_desc_packed, > multiple checks are made whether unmap is performed and whether it is > INDIRECT. > > These two functions are usually called in a loop, and we should put the > check outsid

[PATCH vhost v6 02/10] virtio_ring: packed: remove double check of the unmap ops

2024-03-27 Thread Xuan Zhuo
In the functions vring_unmap_extra_packed and vring_unmap_desc_packed, multiple checks are made whether unmap is performed and whether it is INDIRECT. These two functions are usually called in a loop, and we should put the check outside the loop. And we unmap the descs with VRING_DESC_F_INDIRECT