Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-19 Thread Xuan Zhuo
On Thu, 18 Apr 2024 22:19:33 +0200, Jesper Dangaard Brouer wrote: > > > On 17/04/2024 10.20, Xuan Zhuo wrote: > > On Wed, 17 Apr 2024 12:08:10 +0800, Jason Wang wrote: > >> On Wed, Apr 17, 2024 at 9:38 AM Xuan Zhuo > >> wrote: > >>> > >>> On Tue, 16 Apr 2024 11:24:53 +0800, Jason Wang > >>>

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-18 Thread Matthew Wilcox
On Thu, Apr 18, 2024 at 10:19:33PM +0200, Jesper Dangaard Brouer wrote: > I'm not sure it is "fine" to, explicitly choosing not to use page pool, > and then (ab)use `struct page` member (pp) that intended for page_pool > for other stuff. (In this case create a linked list of pages). > > +#define

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-18 Thread Jesper Dangaard Brouer
On 17/04/2024 10.20, Xuan Zhuo wrote: On Wed, 17 Apr 2024 12:08:10 +0800, Jason Wang wrote: On Wed, Apr 17, 2024 at 9:38 AM Xuan Zhuo wrote: On Tue, 16 Apr 2024 11:24:53 +0800, Jason Wang wrote: On Mon, Apr 15, 2024 at 5:04 PM Xuan Zhuo wrote: On Mon, 15 Apr 2024 16:56:45 +0800, Jaso

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-17 Thread Jason Wang
On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo wrote: > > Now, we chain the pages of big mode by the page's private variable. > But a subsequent patch aims to make the big mode to support > premapped mode. This requires additional space to store the dma addr. > > Within the sub-struct that contains th

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-17 Thread Jason Wang
On Thu, Apr 18, 2024 at 12:15 PM Jason Wang wrote: > > On Wed, Apr 17, 2024 at 4:45 PM Xuan Zhuo wrote: > > > > On Wed, 17 Apr 2024 12:08:10 +0800, Jason Wang wrote: > > > On Wed, Apr 17, 2024 at 9:38 AM Xuan Zhuo > > > wrote: > > > > > > > > On Tue, 16 Apr 2024 11:24:53 +0800, Jason Wang >

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-17 Thread Jason Wang
On Wed, Apr 17, 2024 at 4:45 PM Xuan Zhuo wrote: > > On Wed, 17 Apr 2024 12:08:10 +0800, Jason Wang wrote: > > On Wed, Apr 17, 2024 at 9:38 AM Xuan Zhuo > > wrote: > > > > > > On Tue, 16 Apr 2024 11:24:53 +0800, Jason Wang > > > wrote: > > > > On Mon, Apr 15, 2024 at 5:04 PM Xuan Zhuo > > >

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-17 Thread Xuan Zhuo
On Wed, 17 Apr 2024 12:08:10 +0800, Jason Wang wrote: > On Wed, Apr 17, 2024 at 9:38 AM Xuan Zhuo wrote: > > > > On Tue, 16 Apr 2024 11:24:53 +0800, Jason Wang wrote: > > > On Mon, Apr 15, 2024 at 5:04 PM Xuan Zhuo > > > wrote: > > > > > > > > On Mon, 15 Apr 2024 16:56:45 +0800, Jason Wang >

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-16 Thread Jason Wang
On Wed, Apr 17, 2024 at 9:38 AM Xuan Zhuo wrote: > > On Tue, 16 Apr 2024 11:24:53 +0800, Jason Wang wrote: > > On Mon, Apr 15, 2024 at 5:04 PM Xuan Zhuo > > wrote: > > > > > > On Mon, 15 Apr 2024 16:56:45 +0800, Jason Wang > > > wrote: > > > > On Mon, Apr 15, 2024 at 4:50 PM Xuan Zhuo > > >

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-16 Thread Xuan Zhuo
On Tue, 16 Apr 2024 11:24:53 +0800, Jason Wang wrote: > On Mon, Apr 15, 2024 at 5:04 PM Xuan Zhuo wrote: > > > > On Mon, 15 Apr 2024 16:56:45 +0800, Jason Wang wrote: > > > On Mon, Apr 15, 2024 at 4:50 PM Xuan Zhuo > > > wrote: > > > > > > > > On Mon, 15 Apr 2024 14:43:24 +0800, Jason Wang >

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-15 Thread Jason Wang
On Mon, Apr 15, 2024 at 5:04 PM Xuan Zhuo wrote: > > On Mon, 15 Apr 2024 16:56:45 +0800, Jason Wang wrote: > > On Mon, Apr 15, 2024 at 4:50 PM Xuan Zhuo > > wrote: > > > > > > On Mon, 15 Apr 2024 14:43:24 +0800, Jason Wang > > > wrote: > > > > On Mon, Apr 15, 2024 at 10:35 AM Xuan Zhuo > >

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-15 Thread Xuan Zhuo
On Mon, 15 Apr 2024 16:56:45 +0800, Jason Wang wrote: > On Mon, Apr 15, 2024 at 4:50 PM Xuan Zhuo wrote: > > > > On Mon, 15 Apr 2024 14:43:24 +0800, Jason Wang wrote: > > > On Mon, Apr 15, 2024 at 10:35 AM Xuan Zhuo > > > wrote: > > > > > > > > On Fri, 12 Apr 2024 13:49:12 +0800, Jason Wang

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-15 Thread Jason Wang
On Mon, Apr 15, 2024 at 4:50 PM Xuan Zhuo wrote: > > On Mon, 15 Apr 2024 14:43:24 +0800, Jason Wang wrote: > > On Mon, Apr 15, 2024 at 10:35 AM Xuan Zhuo > > wrote: > > > > > > On Fri, 12 Apr 2024 13:49:12 +0800, Jason Wang > > > wrote: > > > > On Fri, Apr 12, 2024 at 1:39 PM Xuan Zhuo > >

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-15 Thread Xuan Zhuo
On Mon, 15 Apr 2024 14:43:24 +0800, Jason Wang wrote: > On Mon, Apr 15, 2024 at 10:35 AM Xuan Zhuo wrote: > > > > On Fri, 12 Apr 2024 13:49:12 +0800, Jason Wang wrote: > > > On Fri, Apr 12, 2024 at 1:39 PM Xuan Zhuo > > > wrote: > > > > > > > > On Fri, 12 Apr 2024 12:47:55 +0800, Jason Wang

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-14 Thread Jason Wang
On Mon, Apr 15, 2024 at 10:35 AM Xuan Zhuo wrote: > > On Fri, 12 Apr 2024 13:49:12 +0800, Jason Wang wrote: > > On Fri, Apr 12, 2024 at 1:39 PM Xuan Zhuo > > wrote: > > > > > > On Fri, 12 Apr 2024 12:47:55 +0800, Jason Wang > > > wrote: > > > > On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo > >

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-14 Thread Xuan Zhuo
On Fri, 12 Apr 2024 13:49:12 +0800, Jason Wang wrote: > On Fri, Apr 12, 2024 at 1:39 PM Xuan Zhuo wrote: > > > > On Fri, 12 Apr 2024 12:47:55 +0800, Jason Wang wrote: > > > On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo > > > wrote: > > > > > > > > Now, we chain the pages of big mode by the page's

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-11 Thread Xuan Zhuo
On Fri, 12 Apr 2024 13:49:12 +0800, Jason Wang wrote: > On Fri, Apr 12, 2024 at 1:39 PM Xuan Zhuo wrote: > > > > On Fri, 12 Apr 2024 12:47:55 +0800, Jason Wang wrote: > > > On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo > > > wrote: > > > > > > > > Now, we chain the pages of big mode by the page's

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-11 Thread Jason Wang
On Fri, Apr 12, 2024 at 1:39 PM Xuan Zhuo wrote: > > On Fri, 12 Apr 2024 12:47:55 +0800, Jason Wang wrote: > > On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo > > wrote: > > > > > > Now, we chain the pages of big mode by the page's private variable. > > > But a subsequent patch aims to make the big

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-11 Thread Xuan Zhuo
On Fri, 12 Apr 2024 12:47:55 +0800, Jason Wang wrote: > On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo wrote: > > > > Now, we chain the pages of big mode by the page's private variable. > > But a subsequent patch aims to make the big mode to support > > premapped mode. This requires additional space

Re: [PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-11 Thread Jason Wang
On Thu, Apr 11, 2024 at 10:51 AM Xuan Zhuo wrote: > > Now, we chain the pages of big mode by the page's private variable. > But a subsequent patch aims to make the big mode to support > premapped mode. This requires additional space to store the dma addr. > > Within the sub-struct that contains th

[PATCH vhost 3/6] virtio_net: replace private by pp struct inside page

2024-04-10 Thread Xuan Zhuo
Now, we chain the pages of big mode by the page's private variable. But a subsequent patch aims to make the big mode to support premapped mode. This requires additional space to store the dma addr. Within the sub-struct that contains the 'private', there is no suitable variable for storing the DMA