Re: [PATCH vhost] vhost_net: Fix too many vring kick on busypoll

2018-07-01 Thread Jason Wang
On 2018年07月02日 10:52, Toshiaki Makita wrote: On 2018/07/02 11:41, Jason Wang wrote: On 2018年06月30日 00:38, Michael S. Tsirkin wrote: On Fri, Jun 29, 2018 at 05:09:50PM +0900, Toshiaki Makita wrote: Under heavy load vhost busypoll may run without suppressing notification. For example tx zeroc

Re: [PATCH vhost] vhost_net: Fix too many vring kick on busypoll

2018-07-01 Thread Toshiaki Makita
On 2018/06/30 1:38, Michael S. Tsirkin wrote: ... >> Performance numbers: >> >> - Bulk transfer from guest to external physical server. >> [Guest]->vhost_net->tap--(XDP_REDIRECT)-->i40e --(wire)--> [Server] >> - Set 10us busypoll. >> - Guest disables checksum and TSO because of host XDP. >> - M

Re: [PATCH vhost] vhost_net: Fix too many vring kick on busypoll

2018-07-01 Thread Jason Wang
On 2018年07月02日 10:45, Toshiaki Makita wrote: Hi Jason, On 2018/06/29 18:30, Jason Wang wrote: On 2018年06月29日 16:09, Toshiaki Makita wrote: ... To fix this, poll the work instead of enabling notification when busypoll is interrupted by something. IMHO signal_pending() and vhost_has_work() a

Re: [PATCH vhost] vhost_net: Fix too many vring kick on busypoll

2018-07-01 Thread Toshiaki Makita
On 2018/07/02 11:41, Jason Wang wrote: > On 2018年06月30日 00:38, Michael S. Tsirkin wrote: >> On Fri, Jun 29, 2018 at 05:09:50PM +0900, Toshiaki Makita wrote: >>> Under heavy load vhost busypoll may run without suppressing >>> notification. For example tx zerocopy callback can push tx work while >>>